zanna-37 / hass-swipe-navigation

↔️ Swipe through Home Assistant Dashboard views on mobile.
MIT License
349 stars 18 forks source link

Added new config param animate_duration #56

Closed ambroseus closed 1 year ago

ambroseus commented 1 year ago

Added ability to control animate duration via config param animate_duration

zanna-37 commented 1 year ago

Thank you very much for your PR. What is your use case? It is too fast or too slow for you? Or do you just want to add customization?

ambroseus commented 1 year ago

Thank you very much for your PR. What is your use case? It is too fast or too slow for you? Or do you just want to add customization?

it's a little bit slow for my experience :) wanna reduce to 100 ms

ambroseus commented 1 year ago

running tests: Screenshot from 2023-06-24 13-50-01

ambroseus commented 1 year ago

waiting for approve, merge and release 😏

zanna-37 commented 1 year ago

I took the liberty of fixing some minor issues and rewrite the commit message to adhere to conventional commits.

zanna-37 commented 1 year ago

It's on the pre-release v1.12.0. Do you confirm it's working?

ambroseus commented 1 year ago

yes, just switched to pre-release version on my ha instance, set duration to 100 ms - it works as expected 🎉

ambroseus commented 1 year ago

Screenshot_2023-06-27-11-00-22-123_io.homeassistant.companion.android-edit.jpg

Screenshot_2023-06-27-11-47-44-372_io.homeassistant.companion.android-edit.jpg

ambroseus commented 1 year ago

and i'm happy now :)

zanna-37 commented 1 year ago

Me too, and thank you very much for your contribution! Much appreciated 😊