Closed wrabel closed 1 year ago
Hello @wrabel, thank you very very much for contributing!
Just some notes before merging:
enable_mouse_swipe
is shorter and clearerfeat(core): add a flag to allow mouse to swipe
as commit message.
) in the log at line 721Other than that, I like the changes. I can address the points myself if you don't have time.
Hi first two corrected, unfortunately I do not know what you mean in point 3.
btw I love that you used the zod to do it.
I did some minor cosmetic changes, but nothing special. Thank you again for your work! Everything will go live with the new release.
P.S.
I do not know what you mean in point 3.
I Just added the dot at the end of the sentence. =)
logd("Ignoring " + interactionType + ": swiping via mouse is disabled.");
This dot ---^
Can you test the new pre-release v1.13.0
? Everything should be working.
looks fine
@wrabel I learned a new lesson today. TouchEvent might not be defined. For example on Firefox when the device has no touch support. See issue #62
. Anyway, it's fixed now. =)
thanks for information :)
Hi
In care of PC users I added options to be able to swipe through panels with the mouse.