zanna-37 / hass-swipe-navigation

↔️ Swipe through Home Assistant Dashboard views on mobile.
MIT License
322 stars 17 forks source link

swiping via mouse #59

Closed wrabel closed 1 year ago

wrabel commented 1 year ago

Hi

In care of PC users I added options to be able to swipe through panels with the mouse.

zanna-37 commented 1 year ago

Hello @wrabel, thank you very very much for contributing!

Just some notes before merging:

Other than that, I like the changes. I can address the points myself if you don't have time.

wrabel commented 1 year ago

Hi first two corrected, unfortunately I do not know what you mean in point 3.

btw I love that you used the zod to do it.

zanna-37 commented 1 year ago

I did some minor cosmetic changes, but nothing special. Thank you again for your work! Everything will go live with the new release.

P.S.

I do not know what you mean in point 3.

I Just added the dot at the end of the sentence. =)

logd("Ignoring " + interactionType + ": swiping via mouse is disabled.");
                                                         This dot ---^
zanna-37 commented 1 year ago

Can you test the new pre-release v1.13.0? Everything should be working.

wrabel commented 1 year ago

looks fine

zanna-37 commented 12 months ago

@wrabel I learned a new lesson today. TouchEvent might not be defined. For example on Firefox when the device has no touch support. See issue #62. Anyway, it's fixed now. =)

wrabel commented 12 months ago

thanks for information :)