search

zantoku / google-toolbox-for-mac

Automatically exported from code.google.com/p/google-toolbox-for-mac
Apache License 2.0
0 stars 0 forks source link

RunIPhoneUnitTest.sh should have non-zero exit on test failure #12

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Run RunIPhoneUnitTest.sh with a failed test.
2. Check return value $?

What is the expected output? What do you see instead?
Should be non-zero

What version of the product are you using? On what operating system?
trunk/r76; Mac OS X 10.5.5

Please provide any additional information below.
Attached a diff, which is how we patched this locally.

Original issue reported on code.google.com by gabri...@gmail.com on 23 Jan 2009 at 12:31

Attachments:

GoogleCodeExporter commented 9 years ago 
I just submitted a patch to do something similar! You beat me to the post by 84 
minutes! I'll try your patch and 
see if it works better or worse.

Original comment by clifton....@gmail.com on 23 Jan 2009 at 2:01

GoogleCodeExporter commented 9 years ago 
Looks like we might want a merge of this and the patch in 
http://code.google.com/p/google-toolbox-for-
mac/issues/detail?id=12 since someone can turn off the exit call from the 
delegate so we'll keep both issues 
opened until we land something for it.

Original comment by thoma...@gmail.com on 24 Jan 2009 at 1:27

GoogleCodeExporter commented 9 years ago 
oops, i meant 
http://code.google.com/p/google-toolbox-for-mac/issues/detail?id=13

Original comment by thoma...@gmail.com on 24 Jan 2009 at 1:28

GoogleCodeExporter commented 9 years ago 
just landed a code change so the exit status is set, and for the apps that 
directly drive the delegate, then can get 
out the success/fail numbers.

Original comment by thoma...@gmail.com on 30 Jan 2009 at 3:20