search

zap-me / zap_payments

MIT License
0 stars 1 forks source link

Added jsbeautifier to banks_description #10

Closed eoliveros closed 4 years ago

eoliveros commented 4 years ago

when creating/editing the bank_description, it uses jsbeautifier. noticeable when you enter it as one line string.

djpnewton commented 4 years ago

cool looks good, can you give me your test results?

eoliveros commented 4 years ago

results will be in caprover: image

image

djpnewton commented 4 years ago

I mean, have you tested this functionality and is it working ok?

eoliveros commented 4 years ago

I mean, have you tested this functionality and is it working ok?

screenshot is in my previous comment

djpnewton commented 4 years ago

the screenshot looks fine, can you tell me if you have you tested this functionality and is it working ok?

eoliveros commented 4 years ago

the screenshot looks fine, can you tell me if you have you tested this functionality and is it working ok?

The result is the screenshot and it looks ok.

djpnewton commented 4 years ago

have you tested it? A screenshot does not tell me if you have tested the full functionality

have you edited some "untidy" JSON and it gets nicely formatted without making any functional changes to the JSON data?

eoliveros commented 4 years ago

have you tested it? A screenshot does not tell me if you have tested the full functionality

have you edited some "untidy" JSON and it gets nicely formatted without making any functional changes to the JSON data?

yes, i when i entered it as one string, removing spaces in keys and values, it reformats it to the pretty version