zap-me / zap_payments

MIT License
0 stars 1 forks source link

We need to show more context to the user #17

Closed djpnewton closed 4 years ago

djpnewton commented 4 years ago

The user needs more information when:

The info we need is:

eoliveros commented 4 years ago

added the amount in msg.body. Testing and waiting for the email to be sent.

eoliveros commented 4 years ago

not getting the email. will check.

djpnewton commented 4 years ago

is the email still failing?

eoliveros commented 4 years ago

just tested this. and i registered my personal email to see if I'll get the update. So far nothing.

djpnewton commented 4 years ago

I have added you as a collaborator (https://dashboard.heroku.com/apps/zap-bill-payment), check the logs when it sends the email

eoliveros commented 4 years ago

the zap-bll-payment in heroku is sending emails. Is there any way to get the one in caprover to do that as well? I can't remember how to deploy to heroku and with my constant change and test, its better for me to get this environment working.

djpnewton commented 4 years ago

We dont have an instance in caprover yet, you can put one on if you want

eoliveros commented 4 years ago

I have this at the moment:

https://test-zap-bill-payment.caprover.acuerdo.dev

May need to update it though. As well as the config incase something is not matching.

djpnewton commented 4 years ago

Yes, you can deploy it to caprover for testing

eoliveros commented 4 years ago

trying to get this to email but, for some reason its not emailing. cant tell why its not emailing though.

eoliveros commented 4 years ago

checking the docker logs:

--SNIP--
connect sid: 6680d913ac71451191fa4e5d7cee6676
connect sid: 3586a20b3f96455e9983edd2e90395e7
watching address 3MwXqmVwLKF2ZKZ2g2HMcppe667TCLjnmtS for b0159ffc8caf3857
connect sid: 5bfa3949fc0f49db92e9615a3677c91a

--/SNIP--

There's nothing thats triggering the email?

eoliveros commented 4 years ago

ahhh, looks like its not fully uptodate.... pulling updates.

eoliveros commented 4 years ago

deployed and edited to get the amount: image

Will need to cleanup the message though.

Also investigating on how to get the name of the utility in to the message as well.

eoliveros commented 4 years ago

Ok, with the changes to models.py and others, i got the msg to include the bank name as well: image

so the name is also now included as well as the amount in $

djpnewton commented 4 years ago

Cool, now we need a PR to add that info to the invoice status page too

eoliveros commented 4 years ago

invoice status page? You mean this page? image

The amount was already there. To get the utility_name to show up i had to edit the this as well to get the utility_name in the msg as well.

djpnewton commented 4 years ago

no the status page showed to the user, like when they follow the link in the email

On Wed, Sep 9, 2020 at 12:59 PM eoliveros notifications@github.com wrote:

invoice status page? You mean this page? [image: image] https://user-images.githubusercontent.com/47799652/92542112-04f1d900-f29c-11ea-9672-7eecc018e2f5.png

The amount was already there. To get the utility_name to show up i had to edit the this as well to get the utility_name in the msg as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zap-me/zap_bill_payment/issues/17#issuecomment-689233357, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAKLWZPUFPTK5YL2W25WYTSE3HOFANCNFSM4QFTJFHQ .

eoliveros commented 4 years ago

Like this? image

djpnewton commented 4 years ago

yeah but maybe in the main part next to the expiry

On Wed, Sep 9, 2020 at 3:36 PM eoliveros notifications@github.com wrote:

Like this? [image: image] https://user-images.githubusercontent.com/47799652/92551476-2b227380-f2b2-11ea-9da1-3a3642f6c39d.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zap-me/zap_bill_payment/issues/17#issuecomment-689279414, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAKLW3TUBRLH6GFOZE7ZG3SE3Z4HANCNFSM4QFTJFHQ .

eoliveros commented 4 years ago

How about this: image

djpnewton commented 4 years ago

yep