search

zap-zsh / zap

:zap: Zap is a minimal zsh plugin manager
https://www.zapzsh.com/
GNU General Public License v3.0
959 stars 35 forks source link

Installation instructions are not POSIX compliant #187

Open jarkkojs opened 1 month ago

jarkkojs commented 1 month ago

Describe the bug

Installation instructions are not POSIX compliant, which could be useful e.g. when installing zsh starting from busybox.

Steps to reproduce

$ bash --posix -c "zsh <(curl -s https://raw.githubusercontent.com/zap-zsh/zap/master/install.zsh) --branch release-v1 --keep"
bash: -c: line 0: syntax error near unexpected token `('
bash: -c: line 0: `zsh <(curl -s https://raw.githubusercontent.com/zap-zsh/zap/master/install.zsh) --branch release-v1 --keep'

Expected behavior

POSIX compliant alternative:

bash --posix -c "curl -sSf https://raw.githubusercontent.com/zap-zsh/zap/master/install.zsh | zsh -s -- --branch release-v1 --keep"
⚡ Zap - Installer

Screenshots and recordings

No response

OS / Linux distribution

Fedora Linux, macOS

Zsh version

5.9

Zap version

1.2.3

Terminal emulator

Alacritty

If using WSL on Windows, which version of WSL

None

Additional context

No response

jarkkojs commented 1 month ago

It is also somewhat idiomatic pattern among open source projects (e.g. https://www.rust-lang.org/tools/install).