Update stat producerId documentation

zaphiro-technologies / protobuf

A repository including protocol buffer used in Zaphiro's platform

Apache License 2.0

0 stars 0 forks source link

Update stat producerId documentation #64

Closed hiimjako closed 4 months ago

hiimjako commented 4 months ago

Description

Align the producerId description with the Data one, since they are the same.

Changes Made

Related Issues

Checklist

[ ] I have used a PR title that is descriptive enough for a release note.
[ ] I have tested these changes locally.
[ ] I have added appropriate tests or updated existing tests.
[ ] I have tested these changes on a dedicated VM or a customer VM [name of the VM]
[x] I have added appropriate documentation or updated existing documentation.

barecheck[bot] commented 4 months ago

Barecheck - Code coverage report

Total: 16.25% Your code coverage diff: 0.00% ▴ ✅ All code changes are covered

chicco785 commented 4 months ago

IEEE C37.118 is the communication protocol between PMU and PDC I don't think there can be any other type of producer for the 'stat change' message, am I missing something?

the header just specifies the id of the producer, i don't think it makes much of a difference the "type" here, but it could be also a simulator (so not a real PMU), and in fact that's the case we use PMU-SIM

MarcoPignati commented 4 months ago

ok so antoine adjust the labview side so that we expect the mRID to collects the events-emitter outptus please. I had made an issue in gitlab https://gitlab.com/zaphiro-technologies/synchrohub/-/issues/788

AntoineChalons commented 4 months ago

In this extract from our example OP

  <zaphiro:PMU rdf:ID="_PMU-0011">
    <cim:IdentifiedObject.mRID>PMU-0011</cim:IdentifiedObject.mRID>
    <cim:IdentifiedObject.name>PMU-0011</cim:IdentifiedObject.name>
    <cim:Equipment.inService>true</cim:Equipment.inService>
    <zaphiro:PMU.id>11</zaphiro:PMU.id>
  </zaphiro:PMU>

Now the decription is producerId (string): the id of the producer (e.g. a PMU) linked to the dataset. What is the id of PMU 11 described in the extract above?

side note : in other messages 'producerId' is the service that sends the message, e.g. TimeAligner for data notifications

MarcoPignati commented 4 months ago

@chicco785 in this case the producerid is going to be the mRID of the PMU as discussed today.

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud