search

zaphosting / docs

Our ZAP-Hosting Community Guides
https://zap-hosting.com/guides
19 stars 65 forks source link

Contributors Section in DocsItem/Footer #1333

Closed fgalz closed 1 month ago

fgalz commented 1 month ago

This adds a new "Contributors" section to the footer of Docs guides (DocsItem/Footer). The section displays all contributors who have participated in creating or editing the document. ZAP employees are additionally highlighted to differentiate them from other contributors.

image

github-actions[bot] commented 1 month ago

badge

Build Successful! You can find a link to the downloadable artifact below.

Name Link
Commit d11d894bf57c503a787db0fa18c65b51c4d05d2f
Logs https://github.com/zaphosting/docs/actions/runs/11220750905
Download https://github.com/zaphosting/docs/suites/29313158312/artifacts/
fgalz commented 1 month ago

Looks good overall.

Found a minor issue, if a file was previously renamed for example, the GitHub endpoint wouldn't return anyone who committed in that "previous file". Not a big thing, since we don't change file names usually, but something that I noticed. 🤙

Probably difficult to fix or take into account. Not worth the effort. As you say, this rarely happens. 🤙

ThatGuyJacobee commented 1 month ago

Probably difficult to fix or take into account. Not worth the effort. As you say, this rarely happens. 🤙

Indeed, I had a look but there isn't really an easy solution for this, would require a lot of tinkering and accessing more endpoints, not worth it. 👍