search

zaphoyd / websocketpp

C++ websocket client/server library
http://www.zaphoyd.com/websocketpp
Other
7.08k stars 1.98k forks source link

Build issues on C++20 (around constructor syntax of templated structs) #1124

Open ddevienne opened 10 months ago

ddevienne commented 10 months ago

We are advancing our internal stack to GCC12 and MSVC2022 on C++20, and this breaks WebSocketPP (perhaps because of warning-as-error, I'm not the prime mover here, just the one taking the time to report it).

The colleague that did the port used https://github.com/jcelerier/websocketpp/commit/3e761b5aa2d415bbe8cf211c7c9a847e4e5f2044 from https://github.com/jcelerier/websocketpp/tree/develop. But personally I'd prefer the official project to have that fix and a new release. I also see a C++23 deprecation in the open issues as well, which could be part of said minor maintenance release to keep up with newer (stricter?) compilers. WDYT?

rerdavies commented 3 months ago

The "develop" branch has compatibility fixes for C++20. No idea what the state of the "develop" branch is. fwiw, it is 69 commits ahead of the main branch, so somebody has done a lot of work on it (and fixed a LOT of bugs).. :-/