Bugfix: Non ascii-chars in user name

zapier / django-knowledge

Add a help desk or knowledge base to your Django project with only a few lines of boilerplate code.

http://github.com/zapier/django-knowledge

ISC License

486 stars 116 forks source link

Bugfix: Non ascii-chars in user name #24

Closed kjona closed 12 years ago

kjona commented 12 years ago

First and last names of users were treated as non-unicode strings. This lead the application to stop working (decode error) if a user with non-ascii name saved a question. I added two characters to fix this problem - declaring strings as unicode were the user lastname/firstname are read.

PS: Sorry for two separate commits - its the first time I use github ;-) PPS: Thank you for your work. I really like it.

bryanhelmig commented 12 years ago

Wonderful, thanks @kjona! I've merged this in. You may add yourself to the authors/contributors list as well if you like. I'll gladly pull that in.

kjona commented 12 years ago

Thank you for your quick response and the invitation to the contributors list. However, the changes are only two characters - I'll join the list with the next improvement :-)