zapier / django-rest-hooks

:love_letter: Add webhook subscriptions to your Django app.
ISC License
554 stars 132 forks source link

Hooks bound to objects #33

Open stevelacey opened 8 years ago

stevelacey commented 8 years ago

I am trying to building something similar to the webhooks available for GitHub organizations.

I note that GitHub binds its hooks to their organization model i.e. send me all status updates of things within this organization.

I don't see any affordance for this functionality here, is that the case, is it worth adding? I think this is particularly useful combined with user overriding +, or at least I think that's what I want to be doing.

avelis commented 8 years ago

@stevelacey I don't see an affordance either given since the inception of the project. The user object was a way to associate intention to connect a hook event, a model & a user.

I think it would be worth exploring. If you make a PR with this feature I can look at merging it in.

stevelacey commented 8 years ago

I decided to roll my own solution in this case, I do think this and dj-webhooks are the best solutions otherwise though, yours for the threading, dj-webhooks for the more thought out models and notification (delivery) models, another thing I need.

I will make every effort to contribute back if my takeaways from rolling my own are valuable — I think both libraries are quite opinionated towards a form of rest/web hooks that I don't fully appreciate the value you of — in the wild I see far more systems implementing webhooks as per my intended design, and it's hurting my head trying to warp that into something that fits here.

avelis commented 8 years ago

@stevelacey No worries, I appreciate the feedback and writing down some of the challenges you faced in the comments. It most certainly helps.

nsb commented 6 years ago

I did something related to this in PR #52