zapier / prom-aggregation-gateway

An aggregating push gateway for Prometheus
Mozilla Public License 2.0
116 stars 26 forks source link

some refactor and cleanup #38

Closed djeebus closed 1 year ago

djeebus commented 1 year ago

make it clear which router supports the API publicly, vs implementation and monitoring details. also split up some tests, add some around health check to prove it was double encoding, helm chart changes, etc

djeebus commented 1 year ago
[main][~/code/other/prom-aggregation-gateway]$ go test -benchmem -run=^$ -bench ^BenchmarkConcurrentAggregate$ prom-aggregation-gateway -benchtime=10s
goos: linux
goarch: amd64
pkg: prom-aggregation-gateway
cpu: AMD Ryzen 9 5900X 12-Core Processor            
BenchmarkConcurrentAggregate/metric_type_simpleGauge-24                   120742            100521 ns/op           90712 B/op       1403 allocs/op
BenchmarkConcurrentAggregate/metric_type_fullMetrics-24                    71344            173191 ns/op          197539 B/op       3893 allocs/op
BenchmarkConcurrentAggregate/metric_type_multiLabel-24                    189332             69238 ns/op           65427 B/op        693 allocs/op
BenchmarkConcurrentAggregate/metric_type_multiLabelIgnore-24              160431             66936 ns/op           66147 B/op        733 allocs/op
BenchmarkConcurrentAggregate/metric_type_labelFields-24                   197664             68502 ns/op           62792 B/op        583 allocs/op
BenchmarkConcurrentAggregate/metric_type_reorderedLabels-24               202158             63072 ns/op           64147 B/op        633 allocs/op
BenchmarkConcurrentAggregate/metric_type_ignoredLabels-24                 192980             70184 ns/op           65988 B/op        733 allocs/op
PASS
ok      prom-aggregation-gateway        94.144s
[clean-up][~/code/other/prom-aggregation-gateway]$ go test -benchmem -run=^$ -bench ^BenchmarkConcurrentAggregate$ prom-aggregation-gateway -benchtime=10s
goos: linux
goarch: amd64
pkg: prom-aggregation-gateway
cpu: AMD Ryzen 9 5900X 12-Core Processor            
BenchmarkConcurrentAggregate/metric_type_simpleGauge-24                   125487             92524 ns/op           90711 B/op       1403 allocs/op
BenchmarkConcurrentAggregate/metric_type_fullMetrics-24                    72567            165873 ns/op          197537 B/op       3893 allocs/op
BenchmarkConcurrentAggregate/metric_type_multiLabel-24                    184720             65368 ns/op           65427 B/op        693 allocs/op
BenchmarkConcurrentAggregate/metric_type_multiLabelIgnore-24              172918             68257 ns/op           66147 B/op        733 allocs/op
BenchmarkConcurrentAggregate/metric_type_labelFields-24                   180250             70082 ns/op           62792 B/op        583 allocs/op
BenchmarkConcurrentAggregate/metric_type_reorderedLabels-24               174849             69160 ns/op           64147 B/op        633 allocs/op
BenchmarkConcurrentAggregate/metric_type_ignoredLabels-24                 154258             71448 ns/op           65988 B/op        733 allocs/op
PASS
ok      prom-aggregation-gateway        89.447s