Docker image size almost doubled

zapier / prom-aggregation-gateway

An aggregating push gateway for Prometheus

Mozilla Public License 2.0

122 stars 27 forks source link

Docker image size almost doubled #45

Closed sontek closed 1 year ago

sontek commented 1 year ago

ghcr.io/zapier/prom-aggregation-gateway                   v0.5.0        24.6MB
weaveworks/prom-aggregation-gateway                       latest        13.9MB

was this necessary or did we accidentally ship some stuff in the image we don't need?

djeebus commented 1 year ago

I suspect the size of the binary increased due to adding gin, but I can check

djeebus commented 1 year ago

Yeah, the old binary is ~11 MB, ours is ~19 MB; that's most of the difference. The other 2 MB probably comes from using a different base, or being slightly lazy about wiping cached files before deploying, but :shrug: seems acceptable.

mplachter commented 1 year ago

Going to close this for now as this isn't a huge difference since we added more frameworks like Gin. ^