search

zapier / prom-aggregation-gateway

An aggregating push gateway for Prometheus
Mozilla Public License 2.0
124 stars 28 forks source link

Support multiarch docker images #46

Open sontek opened 1 year ago

sontek commented 1 year ago

Currently we only support amd64:

❯ docker image inspect ghcr.io/zapier/prom-aggregation-gateway:v0.5.0|grep -i arch
        "Architecture": "amd64",

We should publish arm images as well.

cwboden commented 1 year ago

Not sure if discussion is preferred here or in the PR, but I took a stab at adding multi-arch support in #81.

Hoping for a merge soon, as we've recently migrated to arm64 nodes, but still would like to use the push gateway! 😁

cwboden commented 1 year ago

This issue can now be closed, since #81 has been merged :)

EDIT: Actually, I think we need to run the github-pages Pipeline before multi-arch is available for consumption, so we can keep this open until then.

cwboden commented 9 months ago

@mplachter Does something need to be done to run the deployment pipeline? I would like to see a new artifact with the fix, but one hasn't kicked off since #81 was merged

CallumD commented 8 months ago

I also need this (thanks @cwboden) so would love to see the build run. Possibly @djeebus can assist?

djeebus commented 8 months ago

Apologies! Thanks for the ping, let me get this released.

yafanasiev commented 8 months ago

@djeebus we are psyched to see this release, but it looks like release pipeline had failed

djeebus commented 8 months ago

Yup, I've got the release pipeline fixed (probably), but there's something odd going on with the skaffold build. Still working on it. Stay tuned!

djeebus commented 8 months ago

Well that was fun and strange. We're good now though! v0.9.0 should be a multiarch image, tested on x86 and an apple m2. Have fun!