search

zapier / prom-aggregation-gateway

An aggregating push gateway for Prometheus
Mozilla Public License 2.0
122 stars 27 forks source link

[Feature] Improve helm chart #70

Open lmolas opened 1 year ago

lmolas commented 1 year ago

Hello,

I would like to use your helm chart to deploy your aggregation gateway but as it is it can not work for us. It lacks some flexibility mainly on additional labels for PodMonitor and ServiceMonitor. For now it is the only blocking thing I see but I will do an exhaustive check. And also I think that it is better to not use latest tag for your docker image. I can submit a PR if you want.

Thx

mplachter commented 1 year ago

@lmolas would love a PR for this 🚀