search

zapier / prom-aggregation-gateway

An aggregating push gateway for Prometheus
Mozilla Public License 2.0
122 stars 27 forks source link

feat: Add additionalLabels support for Pod and Service Monitors #73

Closed VLZZZ closed 1 year ago

VLZZZ commented 1 year ago

This MR adds:

additionalLabels provides an ability to properly discover Monitors using the serviceMonitorSelector.matchLabelsand podMonitorSelector.matchLabels with the prometheus-operator

djeebus commented 1 year ago

Looks good, thanks for the PR! Two things:

  1. Can you get the DCO signed?
  2. Can you add some helm tests showing that it works as expected both with and without labels?
VLZZZ commented 1 year ago

@djeebus Sorry for the force-push mess here, it's been a while since my last contribution, had hard times with the DCO 😄.
I've added unit tests and also added a brief readme section on this unittest plugin.

VLZZZ commented 1 year ago

Hi @djeebus Any updates on this so far? Do you want me to reabase the brach to get it merged?

djeebus commented 1 year ago

looks good! don't think we need a rebase, but we do need you to bump the helm chart version. once that happens, lgtm!

VLZZZ commented 1 year ago

I've decided to bump it to the 0.6.0