search

zapier / prom-aggregation-gateway

An aggregating push gateway for Prometheus
Mozilla Public License 2.0
116 stars 26 forks source link

Bump golang to 1.21.3 and alpine to 3.18 #79

Closed neiljain closed 11 months ago

neiljain commented 11 months ago
djeebus commented 11 months ago

I believe you're going to have to bump the golang version in .tool-versions

neiljain commented 11 months ago

I pushed a few more commits to resolve previous build failures, can we trigger the workflows again to see if that helps?

djeebus commented 11 months ago

While you're upgrading the world, you could swap from quintush/helm-unittest to helm-unittest/helm-unittest, which would let you upgrade it to 0.3.5

neiljain commented 11 months ago

I've instead reverted helm chart related changes to focus this PR only on golang and alpine updates. Best to look into helm chart unit testing related upgrade separately.

djeebus commented 11 months ago

I've instead reverted helm chart related changes to focus this PR only on golang and alpine updates. Best to look into helm chart unit testing related upgrade separately.

good call. I approved the run, lets see how it goes!

djeebus commented 11 months ago

Success, thanks!