search

zapier / prom-aggregation-gateway

An aggregating push gateway for Prometheus
Mozilla Public License 2.0
116 stars 26 forks source link

feat: Add multi-arch support for releases. #81

Closed cwboden closed 10 months ago

cwboden commented 11 months ago

Addresses #46.

Open to changes in the approach, though I confirmed this built locally for me on WSL2.

I elected to keep the non-multi-arch build steps around for backwards compatibility, instead introducing new *-multiarch steps that are now called from the on_release Workflow.

In addition, I updated Earthfile.md and tidied it up so it'll look nicer when rendered.

djeebus commented 11 months ago

Thanks! It looks like you made a release-binaries-multiarch, but the existing release-binaries is already multiarch (since build-binaries, which provides the binaries, is itself multiarch). Unless I'm missing something, want to remove the release-binaries-multiarch target? Everything else looks good!

cwboden commented 10 months ago

@djeebus Updated! Let me know if there's anything else you'd like me to touch up. Cheers.

mplachter commented 10 months ago

@cwboden, it looks like this got out of date with the upstream, would love to get this in let me know when you can fix it 🙇

cwboden commented 10 months ago

@mplachter Done

djeebus commented 10 months ago

yup, looks good, thanks!