search

zapier / zapier-platform

The SDK for you to build an integration on Zapier
https://platform.zapier.com
Other
343 stars 187 forks source link

Version conlfict between `marked` and `marked-terminal` #489

Open the-csaba opened 2 years ago

the-csaba commented 2 years ago

Bug Description

Unresolvable peer dependency because version conlfict between marked and marked-terminal. The marked-terminal 4.1.1 is requests "^1.0.0 || ^2.0.0" as peer dependency, while the marked requested as "4.0.10" from zapier-platform-cli.

The marked-terminal v5.x is the first to support v4.x from marked.

Note: the zapier command not installed as result of the error, but --force install seemingly works.

related: #471

Reproduction Steps

  1. (optional) uninstall all global npm packages
  2. install zapier-platform-cli
install output ``` ~ ❯ npm ls 5.33s 12:58:06 /Users/csaba └── (empty) ~ ❯ npm i zapier-platform-cli -g 12:58:13 npm WARN ERESOLVE overriding peer dependency npm WARN While resolving: marked-terminal@4.1.1 npm WARN Found: marked@4.0.10 npm WARN node_modules/zapier-platform-cli/node_modules/marked npm WARN marked@"4.0.10" from zapier-platform-cli@11.3.0 npm WARN node_modules/zapier-platform-cli npm WARN zapier-platform-cli@"*" from the root project npm WARN npm WARN Could not resolve dependency: npm WARN peer marked@"^1.0.0 || ^2.0.0" from marked-terminal@4.1.1 npm WARN node_modules/zapier-platform-cli/node_modules/marked-terminal npm WARN marked-terminal@"4.1.1" from zapier-platform-cli@11.3.0 npm WARN node_modules/zapier-platform-cli npm WARN npm WARN Conflicting peer dependency: marked@2.1.3 npm WARN node_modules/marked npm WARN peer marked@"^1.0.0 || ^2.0.0" from marked-terminal@4.1.1 npm WARN node_modules/zapier-platform-cli/node_modules/marked-terminal npm WARN marked-terminal@"4.1.1" from zapier-platform-cli@11.3.0 npm WARN node_modules/zapier-platform-cli npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated npm WARN deprecated har-validator@5.1.5: this library is no longer supported npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead. npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142 npm WARN deprecated cli-ux@4.9.3: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info. npm WARN deprecated cli-ux@5.6.7: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info. added 1189 packages, and audited 1190 packages in 39s 99 packages are looking for funding run `npm fund` for details 9 vulnerabilities (8 moderate, 1 high) To address issues that do not require attention, run: npm audit fix To address all issues, run: npm audit fix --force Run `npm audit` for details. ```

Version Info

zapzap commented 2 years ago

This issue has been copied into our private issue tracker (as PDE-3029). Thanks for the report! We'll update this as we learn more.

xavdid commented 2 years ago

Thanks @om4csaba! I'll take a look.

In the meantime, you can use CLI@11.2.0 until we can release a fix for this.

eliangcs commented 2 years ago

FWIW, this warning message doesn't stop me from installing zapier-platform-cli@11.3.x. I'm using nvm. My install output:

$ node --version
v14.19.0
$ npm --version
6.14.16
$ npm i -g zapier-platform-cli
npm WARN deprecated cli-ux@5.6.7: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated cli-ux@4.9.3: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
/Users/eliang/.nvm/versions/node/v14.19.0/bin/zapier -> /Users/eliang/.nvm/versions/node/v14.19.0/lib/node_modules/zapier-platform-cli/src/bin/run
npm WARN jscodeshift@0.12.0 requires a peer of @babel/preset-env@^7.1.6 but none is installed. You must install peer dependencies yourself.
npm WARN marked-terminal@4.1.1 requires a peer of marked@^1.0.0 || ^2.0.0 but none is installed. You must install peer dependencies yourself.

+ zapier-platform-cli@11.3.1
added 1001 packages from 502 contributors in 56.493s

$ zapier -v
* CLI version: 11.3.1
* Node.js version: v14.19.0
* OS info: darwin-x64
* `zapier-platform-core` dependency: 11.3.1
$ which zapier
/Users/eliang/.nvm/versions/node/v14.19.0/bin/zapier