zapier / zapier-platform

The SDK for you to build an integration on Zapier
https://platform.zapier.com
Other
344 stars 188 forks source link

[Bug]: 15.7.3 is broken on Node 20 #799

Open pieterbeulque opened 4 months ago

pieterbeulque commented 4 months ago

Bug Description

Looks like an ESM / CJS mixup in a dependency?

(node:58561) [ERR_REQUIRE_ESM] Error Plugin: zapier-platform-cli [ERR_REQUIRE_ESM]: require() of ES Module /Users/pieterbeulque/Library/pnpm/global/5/.pnpm/chalk@5.3.0/node_modules/chalk/source/index.js from /Users/pieterbeulque/Library/pnpm/global/5/.pnpm/zapier-platform-cli@15.7.3_encoding@0.1.13_mem-fs-editor@9.7.0_mem-fs@2.3.0__mem-fs@2.3.0/node_modules/zapier-platform-cli/src/oclif/hooks/renderMarkdownHelp.js not supported.
Instead change the require of index.js in /Users/pieterbeulque/Library/pnpm/global/5/.pnpm/zapier-platform-cli@15.7.3_encoding@0.1.13_mem-fs-editor@9.7.0_mem-fs@2.3.0__mem-fs@2.3.0/node_modules/zapier-platform-cli/src/oclif/hooks/renderMarkdownHelp.js to a dynamic import() which is available in all CommonJS modules.
module: @oclif/config@1.18.10
task: runHook init
plugin: zapier-platform-cli
root: /Users/pieterbeulque/Library/pnpm/global/5/.pnpm/zapier-platform-cli@15.7.3_encoding@0.1.13_mem-fs-editor@9.7.0_mem-fs@2.3.0__mem-fs@2.3.0/node_modules/zapier-platform-cli
See more details with DEBUG=*
(Use `node --trace-warnings ...` to show where the warning was created)
    Error: require() of ES Module
    /Users/pieterbeulque/Library/pnpm/global/5/.pnpm/chalk@5.3.0/node_modules/chalk/source/index.js from
    /Users/pieterbeulque/Library/pnpm/global/5/.pnpm/zapier-platform-cli@15.7.3_encoding@0.1.13_mem-fs-editor@9.7.0_mem-fs@2.3.
    0__mem-fs@2.3.0/node_modules/zapier-platform-cli/src/oclif/commands/test.js not supported.
    Instead change the require of index.js in /Users/pieterbeulque/Library/pnpm/global/5/.pnpm/zapier-platform-cli@15.7.3_encod
    ing@0.1.13_mem-fs-editor@9.7.0_mem-fs@2.3.0__mem-fs@2.3.0/node_modules/zapier-platform-cli/src/oclif/commands/test.js to a
    dynamic import() which is available in all CommonJS modules.
    Code: ERR_REQUIRE_ESM

Reproduction Steps

Any zapier command fails

Zapier Platform version

15.7.3

Node.js version

v20.13.1

Your Operating System

macOS 14.5

npm/yarn version

pnpm 9.2.0

App ID

No response

More Details

No response

pieterbeulque commented 4 months ago

Hm, never mind. I thought this was broken because I was running zapier test and that didn't give me any output.

It throws the same warning when running zapier build, or zapier push, but it doesn't block it from running completely.

kreddlear commented 4 months ago

Hi @pieterbeulque ! Thanks for reaching out, apologies for the confusing error there. It looks like when we updated some dependencies in this PR, some of those dependency updates caused this issue. We'll look into it and make sure it's resolved, but thanks for confirming it's not a blocker!

Edit: Created PDE-5128 to investigate this.