zapier / zapier-platform

The SDK for you to build an integration on Zapier
https://docs.zapier.com/platform
Other
348 stars 188 forks source link

[PDE-5214] chore(cli): Oclif upgraded to v4 #890

Closed szchenghuang closed 3 weeks ago

szchenghuang commented 1 month ago

This PR primarily upgrades Oclif from v1 to v4. The primary commit is 0e421a55d5fbfed459a630da94c13688b57205a6.

Command flags are defined differently.

flags from @oclif/command is replaced with Flags from @oclif/core.

Before

const { flags } = require('@oclif/command');
flags.boolean({ ... });

After

const { Flags } = require('@oclif/core');
Flags.boolean({ ... });

Command args are defined differently.

It's an object keyed by arg names rather than an array previously.

Before

SomeCommand.args = [{
  name: 'somArgName',
  ...
}];

After

SomeCommand.args = {
  someArgName: {
    ...
  },
};

yarn outdated --depth=3

Outdated Oclif dependencies should be gone.

Other commits are supporting changes.

szchenghuang commented 3 weeks ago

Very exciting that all tests are passing (and there's new ones!) I ran a few commands locally as well and all worked as expected. Left a few final questions/comments

@rnegron Thanks for taking a look. I addressed your feedback. Let me know if there are any changes you'd like to add.