search

zapmaker / GrblHoming

QT-based gcode user interface for grbl on arduino
GNU General Public License v3.0
320 stars 190 forks source link

Fix the remaining compiler warnings on MacOS/clang #69

Closed chrisy closed 10 years ago

chrisy commented 10 years ago

Clang doesn't like the gcc pragmas to ignore warnings; since this is used just to ignore unused variables, we can use the Q_UNUSED() macro instead (which just expands to (void)name anyway which is portable).

I now get completely clean builds on Windows (MinGW-gcc), Linux and MacOS. Yay!

zapmaker commented 10 years ago

Thanks for fixing all these compile-time issues. I merged all your proposals but did have to fix a problem with the jog combobox logic, can you please pull and verify.

chrisy commented 10 years ago

Very welcome ­ this application is such an improvement over the universal gcode sender.

I¹ll go check the Qt 4 fixes you made to my jogStep thingy shortly. Yes, I¹m using 5. In my defense, I have never touched Qt before :)

As an aside, I¹m working on adding some little labels to show when grbl is in absolute versus relative mode (I keep getting stung when I forget!) and some other state stuff reported by $G.

Cheers, Chris.

chrisy commented 10 years ago

Your fixes work just fine on 5.2.1, though I swear I had the signal connection in my original patch, but I must have broken it before I sent the pull request, oh well! Thanks again.

Chris

chrisy commented 10 years ago

Argh. I worked out what I did, and I spotted an error in the pull request I sent – all of the decX/Y/Z/4th methods are missing a ‘-‘ minus sign before jogStep. I’ll submit a pull to fix that – sorry!

LETARTARE commented 10 years ago

Good audit work.