search

zappa / Zappa

Serverless Python
https://zappa.ws/zappa
MIT License
3.35k stars 362 forks source link

Allow to recursively search package #1270

Closed mcoconnor closed 7 months ago

mcoconnor commented 1 year ago

Description

Enables recursive mode for glob when processing the exclude_glob setting during package assembly. This allows the use of the ** operator in glob strings and brings the functionality in line with existing documentation.

GitHub Issues

Reported here: https://github.com/zappa/Zappa/issues/1269

coveralls commented 1 year ago

Coverage Status

coverage: 74.688%. remained the same when pulling ddd6b655e9aec0088d020c0ce00a197f83920cb4 on CCITatBCM:allow_exclude_glob_recursive into f2f03ba8b58c9e2bdbbff7b5e8c905e3a8c08021 on zappa:master.

mcoconnor commented 1 year ago

Thanks for the very thoughtful and thorough review (especially for such an apparently minor change). I'll be happy to add some tests when I have time to swing back to this. You've asked some interesting questions about performance management and I agree it would be nice to characterize the failure modes a little more and consider how to handle or document them. I'm not sure about including those in the test suite though--seems like intentionally triggering performance issues in a unit test will be a pain for anyone running tests going forward, though I'm open to other opinions.

I'll have to think a little bit about what mitigations might look like in this scenario; to a degree, I feel that either preemptively bombing the process (e.g. a timeout) or executing a halfway correct solution (e.g. limiting the number of results processed) could lead to more frustrating bugs than an obvious failure with a long-running process. The other good thing is that this affects a relatively early part of the deploy/update process so if it does hang, there isn't a lot of garbage that will be left other than the temp file tree that was being operated on.

github-actions[bot] commented 8 months ago

Hi there! Unfortunately, this PR has not seen any activity for at least 90 days. If the PR is still relevant to the latest version of Zappa, please comment within the next 10 days if you wish to keep it open. Otherwise, it will be automatically closed.

github-actions[bot] commented 7 months ago

Hi there! Unfortunately, this PR was automatically closed as it had not seen any activity in at least 100 days. If the PR is still relevant to the latest version of Zappa, please open a new PR.