Zappa tries to create new S3 bucket when it can't access the already existing one

lmuther8 commented 8 months ago

Context

If a user calls zappa update {{stage}} without the AWS s3:ListBucket permission the upload_to_s3 function in core.py it tries to create a new bucket instead of alerting the person they cannot access the bucket.

Expected Behavior

The zappa update {{stage}} call should error out and alert the user they cannot access the bucket they are trying to.

Actual Behavior

The zappa update {{stage}} continues and creates a new s3 bucket or, in my case errors out because the does not have permission to create a new S3 bucket.

Steps to Reproduce

Successfully deploy a zappa project

Create an AWS user or role with the following permissions.

{
"Version": "2012-10-17",
"Statement": [
    {
        "Sid": "VisualEditor0",
        "Effect": "Allow",
        "Action": "logs:UpdateLogDelivery",
        "Resource": "*"
    },
    {
        "Sid": "VisualEditor1",
        "Effect": "Allow",
        "Action": [
            "lambda:UpdateFunctionCode",
            "s3:PutObject",
            "s3:GetObject",
            "lambda:GetFunction"
        ],
        "Resource": [
            "arn:aws:lambda:*:<account>:function:*",
            "arn:aws:s3:::*/*"
        ]
    }
]
}

Call zappa update {{stage}}

Your Environment

Zappa version used: 0.58.0
Operating System and Python version: MacOS Python 3.11

github-actions[bot] commented 5 months ago

Hi there! Unfortunately, this Issue has not seen any activity for at least 90 days. If the Issue is still relevant to the latest version of Zappa, please comment within the next 10 days if you wish to keep it open. Otherwise, it will be automatically closed.

lmuther8 commented 4 months ago

This issue still exists

zappa / Zappa