[Migrated] switching "keep_warm" off doesn't work

jneves commented 3 years ago

Originally from: https://github.com/Miserlou/Zappa/issues/1915 by filthysocks

If you switch the keep_warm functionality on and then back off again then the cloudwatch rule is NOT deleted.

Context

If you set keep_warm to true, deploy set it to false and deploy again then the cloudwatch rule is not deleted. Thus, the function will still be kept warm.

Expected Behavior

if keep_warm: false, then the function should not be kept warm

Actual Behavior

it is kept warm

Possible Fix

not sure ...

Steps to Reproduce

deploy a function with "keep_warm": true
update this function with "keep_warm": false

Your Environment

Zappa version used: 0.48.2
Operating System and Python version: ubuntu 18.04 python 3.7.3
The output of pip freeze: appdirs==1.4.3 argcomplete==1.9.3 aspy.yaml==1.3.0 atomicwrites==1.3.0 attrs==19.1.0 black==19.3b0 boto3==1.9.194 botocore==1.12.194 certifi==2019.6.16 cfgv==2.0.1 cfn-flip==1.2.1 chardet==3.0.4 Click==7.0 cognitojwt==1.1.0 coverage==4.5.4 dash==1.0.1 dash-auth==1.3.2 dash-bootstrap-components==0.6.3 dash-core-components==1.0.0 dash-daq==0.1.0 dash-google-auth==0.1.2 dash-html-components==1.0.0 dash-renderer==1.0.0 dash-table==4.0.1 docutils==0.14 durationpy==0.5 ecdsa==0.13.2 Flask==1.1.1 Flask-Cognito==1.13 Flask-Compress==1.4.0 Flask-Dance==2.2.0 Flask-SeaSurf==0.2.2 future==0.16.0 hjson==3.0.1 identify==1.4.5 idna==2.8 importlib-metadata==0.18 itsdangerous==1.1.0 Jinja2==2.10.1 jmespath==0.9.3 kappa==0.6.0 lambda-packages==0.20.0 MarkupSafe==1.1.1 more-itertools==7.2.0 nodeenv==1.3.3 numpy==1.16.4 oauthlib==3.0.2 pandas==0.24.2 pkg-resources==0.0.0 placebo==0.9.0 plotly==4.0.0 pluggy==0.12.0 pre-commit==1.17.0 py==1.8.0 pyasn1==0.4.5 pytest==4.3.1 pytest-cov==2.7.1 python-dateutil==2.6.1 python-jose==3.0.1 python-slugify==1.2.4 pytz==2019.1 PyYAML==5.1.1 requests==2.7.0 requests-oauthlib==1.2.0 retrying==1.3.3 rsa==4.0 s3transfer==0.2.1 six==1.12.0 toml==0.10.0 tqdm==4.19.1 troposphere==2.4.9 ua-parser==0.8.0 Unidecode==1.1.1 urllib3==1.25.3 URLObject==2.4.3 virtualenv==16.6.2 Werkzeug==0.15.5 wsgi-request-logger==0.4.6 zappa==0.48.2 zipp==0.5.2

github-actions[bot] commented 7 months ago

Hi there! Unfortunately, this Issue has not seen any activity for at least 90 days. If the Issue is still relevant to the latest version of Zappa, please comment within the next 10 days if you wish to keep it open. Otherwise, it will be automatically closed.

github-actions[bot] commented 6 months ago

Hi there! Unfortunately, this Issue was automatically closed as it had not seen any activity in at least 100 days. If the Issue is still relevant to the latest version of Zappa, please open a new Issue.

zappa / Zappa