mingw-w64/gcc-14 error for implicit declaration of function

ileanadumitrescu95 commented 6 months ago

mingw-w64 build for zvbi errors due to gcc-14 implicit declaration of function.

See issue https://github.com/zapping-vbi/zvbi/issues/43 for more details.

nanake commented 6 months ago

I can confirm this proposed PR fixes #43 for me.

Since mingw-gcc-14 is not available on Debian. You can verify using following docker:

docker run --rm -it ghcr.io/nanake/win64-nonfree:latest

git-mini-clone https://github.com/zapping-vbi/zvbi.git 5c19aaaafd62f0c120ab33731ccf2cf93e2f7fed zvbi
cd zvbi

autoreconf -i

./configure --prefix="$FFBUILD_PREFIX" --host="$FFBUILD_TOOLCHAIN" --disable-{shared,bktr,dvb,examples,nls,proxy,tests} --enable-static --with-pic --without-{doxygen,x}

make -C src -j"$(nproc)"
make -C src install
make SUBDIRS=. install

ileanadumitrescu95 commented 6 months ago

Thank you for testing! I am unable to test, since I can not pull the docker image provided. I receive the following error: docker: failed to register layer: Error processing tar file(exit status 1): archive/tar: invalid tar header.

However, I believe this pull request is ready to be merged, and I will close the associated issue. :)

nanake commented 6 months ago

Thanks for the fix. 🎉

It's zstd compressed image. You want docker version >= 23 to pull such image. Sorry for inconvenience.

zapping-vbi / zvbi

mingw-w64/gcc-14 error for implicit declaration of function #45