zaproxy / action-baseline

A GitHub Action for running the ZAP Baseline scan
Apache License 2.0
309 stars 55 forks source link

added default xml report file #105

Closed DPleckauskas closed 5 months ago

DPleckauskas commented 1 year ago

Currently using -x flag fails as a default xml file is not being created. XML reports are needed if using dashboarding tools such as DefectDojo as it cannot parse the other file formats produced.

Fix #104

thc202 commented 1 year ago

You need to update the dist.

thc202 commented 1 year ago

What are you trying to solve specifically? Just the creation of the placeholder? The issue also mentions the artifact but these changes will not address that.

thc202 commented 1 year ago

The changelog needs to be updated.

DPleckauskas commented 1 year ago

Yes this will create the placeholder for XML report generation. Currently, when using the -x flag no XML report is generated.

Unfortunately it seems the uploadArtifacts code is not a part of this repo thus the xml report will not be uploaded to artifacts.

thc202 commented 5 months ago

Closing, per change done in #124 this is no longer needed (i.e. cmd_options should now work fine). There's still the change for upload of the artifact but that would be other changes (and elsewhere).