search

zaproxy / action-baseline

A GitHub Action for running the ZAP Baseline scan
Apache License 2.0
314 stars 58 forks source link

Feature Request: Allow specifying artifact name #45

Closed iamjoeker closed 1 year ago

iamjoeker commented 3 years ago

I use a single workflow file to run zap scans on multiple sites. Each site is its own job so they can fail or succeed independently. However, since the artifact name is hard-coded, only the report of the last job to complete is saved.

Would the project be open to a adding support for specifying the artifact name as an option? I'd be glad to submit PRs both here and in actions-common to add this.

psiinon commented 3 years ago

Sounds good to me! PR much appreciated :)

AlexDCraig commented 3 years ago

I would also like this. Maybe I will work on this sometime.

AlexDCraig commented 3 years ago

@psiinon this issue is resolved with the merging in of this patch to the upstream common library (https://github.com/zaproxy/actions-common/pull/15) and this patch to this repo (https://github.com/zaproxy/action-baseline/pull/64)

Israphel commented 2 years ago

is this feature available to be used yet?

psiinon commented 2 years ago

Sorry no, #64 hasnt been merged yet - its still WIP, I'll see whats blocking it...

Israphel commented 2 years ago

I'm using a workaround for the moment, if anybody is interested:

  job-one:
    name: Dast report for site one
    runs-on: ubuntu-latest
    steps:
      - name: ZAP Scan
        uses: zaproxy/action-api-scan@v0.1.0
        with:
          issue_title: site-one
          token: ${{ secrets.GITHUB_TOKEN }}
          fail_action: false
          target: 'https://siteone.com'
          format: openapi

      - name: Upload report
        uses: actions/upload-artifact@v3
        with:
          name: custom_name.zip
          path: zap_scan.zip