zaproxy / action-full-scan

A GitHub Action for running the ZAP Full scan
Apache License 2.0
265 stars 50 forks source link

Github Actions: Node.js 12 actions are deprecated #61

Closed akarmyzov closed 1 year ago

akarmyzov commented 1 year ago

Github Actions complains that Node.js version 12 is deprecated or will be soon:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: zaproxy/action-full-scan@v0.4.0. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Could Node.js version for ZAP scan Github Action be updated to 16?

kingthorin commented 1 year ago

It already is. GitHub is displaying that on all action runs.

https://github.com/zaproxy/action-full-scan/commit/320094d699002dd2ad1a046d783466b963216128

marcellmueller commented 1 year ago

The last release was in May 2022 and this fix was merged in October 2022. Looks like this is still an issue with just this action as we have updated the rest of our actions and only have a warning for this one.

kingthorin commented 1 year ago

@marcellmueller until we are ready to release you can reference the action by commit sha to get the latest.

marcellmueller commented 1 year ago

@kingthorin oh nice, thanks for the heads up! I think we will wait for the next release but this is good to know incase.