added floating window to indicate and stop recording

[aryangupta701]

• added a floating window to indicate and stop the recording process

[aryangupta701]

I will create a separate PR for reporting the recorded actions over this floating window

[thc202]

This should be rebased and use/extract constants. (It has conflicts too.)

[thc202]

It seems the events done to the floating window might also end up being recorded to the scripts, e.g.:

    {
      "windowHandle": "windowHandle1",
      "type": "id",
      "element": "ZapfloatingDiv",
      "index": 4,
      "enabled": true,
      "elementType": "ZestClientElementClick"
    }

[aryangupta701]

ohhh Thank you. Forgot to test that.

[aryangupta701]

ready for review

[thc202]

Sometimes the floating window is almost hidden, e.g.:

[aryangupta701]

fixing this

[aryangupta701]

if someone drag and drop to a particular location it will stay at that location even if the window size changes that may lead to the loss of the floating window. Thinking about how we can fix this

[aryangupta701]

Fixed :)

[thc202]

Looks better but it's still partially hidden:

(That's the default window size when launching the browser from ZAP.)

[aryangupta701]

Fixing..

[aryangupta701]

I think this is again a mac related issue. For me it works fine. I can't reproduce this behavior @thc202

[thc202]

What information can I provide?

[aryangupta701]

I can suggest some hit and trials. Can you test them please?

1. try changing https://github.com/zaproxy/browser-extension/pull/63/files#diff-326f362eacd2a9bea9debec8ede73c13ba68fdcbbb2c69a9f40a90d5afc3d5b0R246 replace -105 with -100

[aryangupta701]

I am able to reproduce this issue. I wonder why the chrome browser launched from ZAP and the the one which I directly use is rendering css differently.

[aryangupta701]

Ohh I got it. This is because of the website only. It has some css which is being applied over this floating window as well. So I guess I will need to use frames.

[aryangupta701]

ready for review

[thc202]

Thank you!