search

zaproxy / zap-api-dotnet

ZAP Dot NET API
Apache License 2.0
35 stars 35 forks source link

Enable cookies on WebClient. #3

Open binarymist opened 8 years ago

binarymist commented 8 years ago

If ClientApi.PostToUrl is not generic enough for main stream consumption, consumers could make an extension method out of it. Access to the WebClient's headers are required in ClientApi.PostToUrl Currently consumers have to maintain this locally. Once this is included, consumers can then depend on the NuGet package instead.

gmaran23 commented 8 years ago

Hi, Thanks for the pull request. It took me a little while to get around this pull request.

  1. Do you have a sample of how the public method ClientApi.PostToUrl can come in handy for the api consumers?
  2. What is the use case for this method?

It seems like in order to support this method ClientApi.PostToUrl (and also send some cookie information along the request) we need to restructure the IWebClient interface rather than directly modifying the SystemWebClient class.

binarymist commented 8 years ago

I no longer have access to this .NET environment, and because it's been so long, is no longer fresh in my head. I've passed this onto my client that I was working for at the time. My client will hopefully provide feedback soon.