zaproxy / zap-hud

The ZAP Heads Up Display (HUD)
Apache License 2.0
251 stars 151 forks source link

Remove `vue-template-compiler` #1287

Closed njmulsqb closed 1 year ago

njmulsqb commented 1 year ago

This commit upgrades the vue version to 2.7 which is the LTS version of 2.x series. This also removes the vue-template-compiler dependency as it is not required anymore. More: https://v2.vuejs.org/v2/guide/migration-vue-2-7.html#Vue-CLI-webpack

I have tested HUD after this upgrade and it seems to work fine.

Part of #1110

thc202 commented 1 year ago

There's already a dependabot PR updating Vue, #1203. Since it has a lot less changes I'm inclined to merge that one first and then remove vue-template-compiler in this one.

njmulsqb commented 1 year ago

vue-template-compiler is no longer required with 2.7 image yeah either way its fine, you can merge that one first and then this.

psiinon commented 1 year ago

@njmulsqb we've tested and merged #1203 so if you fix the conflicts we can test this one next 😁

njmulsqb commented 1 year ago

Done; my bad with DCO; now trying to sign off is resulting in failure of rebase.

thc202 commented 1 year ago

Did you install after doing the latest changes? I'm seeing only these:

diff --git a/package-lock.json b/package-lock.json
index c4c67a99..5831502c 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -20,7 +20,6 @@
         "lint-staged": "^12.4.1",
         "vue-loader": "^17.0.0",
         "vue-style-loader": "^4.1.3",
-        "vue-template-compiler": "^2.7.14",
         "webpack": "^5.72.0",
         "webpack-cli": "^4.10.0",
         "xo": "^0.37.1"
@@ -2991,12 +2990,6 @@
         "node": ">=6"
       }
     },
-    "node_modules/de-indent": {
-      "version": "1.0.2",
-      "resolved": "https://registry.npmjs.org/de-indent/-/de-indent-1.0.2.tgz",
-      "integrity": "sha1-sgOOhG3DO6pXlhKNCAS0VbjB4h0=",
-      "dev": true
-    },
     "node_modules/debug": {
       "version": "4.3.1",
       "resolved": "https://registry.npmjs.org/debug/-/debug-4.3.1.tgz",
@@ -5751,15 +5744,6 @@
         "minimalistic-assert": "^1.0.1"
       }
     },
-    "node_modules/he": {
-      "version": "1.2.0",
-      "resolved": "https://registry.npmjs.org/he/-/he-1.2.0.tgz",
-      "integrity": "sha512-F/1DnUGPopORZi0ni+CvrCgHQ5FyEAHRLSApuYWMmrbSwoN2Mn/7k+Gl38gJnR7yyDZk6WLXwiGod1JOWNDKGw==",
-      "dev": true,
-      "bin": {
-        "he": "bin/he"
-      }
-    },
     "node_modules/hmac-drbg": {
       "version": "1.0.1",
       "resolved": "https://registry.npmjs.org/hmac-drbg/-/hmac-drbg-1.0.1.tgz",
@@ -10954,16 +10938,6 @@
         "node": ">=4.0.0"
       }
     },
-    "node_modules/vue-template-compiler": {
-      "version": "2.7.14",
-      "resolved": "https://registry.npmjs.org/vue-template-compiler/-/vue-template-compiler-2.7.14.tgz",
-      "integrity": "sha512-zyA5Y3ArvVG0NacJDkkzJuPQDF8RFeRlzV2vLeSnhSpieO6LK2OVbdLPi5MPPs09Ii+gMO8nY4S3iKQxBxDmWQ==",
-      "dev": true,
-      "dependencies": {
-        "de-indent": "^1.0.2",
-        "he": "^1.2.0"
-      }
-    },
     "node_modules/watchpack": {
       "version": "2.3.1",
       "resolved": "https://registry.npmjs.org/watchpack/-/watchpack-2.3.1.tgz",
diff --git a/package.json b/package.json
index 143d5946..dc17e3a9 100644
--- a/package.json
+++ b/package.json
@@ -107,7 +107,6 @@
     "lint-staged": "^12.4.1",
     "vue-loader": "^17.0.0",
     "vue-style-loader": "^4.1.3",
-    "vue-template-compiler": "^2.7.14",
     "webpack": "^5.72.0",
     "webpack-cli": "^4.10.0",
     "xo": "^0.37.1"
njmulsqb commented 1 year ago

Yes I have installed after changes; these should be the only changes as well because I have just removed vue-template-compiler

thc202 commented 1 year ago

I pushed the last commit with the signed off of the first.

thc202 commented 1 year ago

Thank you!

njmulsqb commented 1 year ago

@thc202 why are the CI tests failing on this PR?

kingthorin commented 1 year ago

The tests have been failing for a while. No one has had a chance to dig into it.