search

zaproxy / zap-hud

The ZAP Heads Up Display (HUD)
Apache License 2.0
252 stars 152 forks source link

Remove iframe scroll (deprecated) #1311

Closed njmulsqb closed 8 months ago

njmulsqb commented 8 months ago

scroll attribute is deprecated on iframe; it is replaced with overflow: hidden; CSS property. Reference: https://support.moonpoint.com/network/web/html/css/iframe-obsolete-elements.php

njmulsqb commented 8 months ago

Hi,

Kindly take out time to test and merge this small improvement to HUD :)

psiinon commented 8 months ago

On my list!

thc202 commented 8 months ago

This makes the bottom panel to have a scrollbar in macOS, while with attribute it didn't have it. (I don't mind much either way, since with the default settings it will not be shown unless scrolling in the frame.)

njmulsqb commented 8 months ago

(I don't mind much either way, since with the default settings it will not be shown unless scrolling in the frame.)

So should we merge this as is?

thc202 commented 8 months ago

Thank you!

So should we merge this as is?

That's fine by me but this will be checked further.

psiinon commented 8 months ago

I dont get the scrollbar on my mac - maybe its screensize dependant? In any case, I'm good to merge 😁