zaproxy / zap-hud

The ZAP Heads Up Display (HUD)
Apache License 2.0
253 stars 151 forks source link

Request / response highlight option #360

Open psiinon opened 5 years ago

psiinon commented 5 years ago

It would be great to have an option to highlight one (or more?) strings in the Request / Response dialog. We could use this for alert 'evidence' and for search results. The ZAP desktop uses highlighting in this way ;)

psiinon commented 5 years ago

@jaywon - sent you a collaboration invite : looks like I cant assign issues to you until you accept that

jaywon commented 5 years ago

@psiinon accepted!

thc202 commented 5 years ago

Assigned :)

psiinon commented 5 years ago

@jaywon have you made any progress on this?

Having looked at it I think its non trivial :/ But we still really want this functionality. Currently the requests and responses are text areas, which cant typically have highlighting applied to. There are some options:

Thoughts anyone?

dscrobonia commented 5 years ago

Some clever JS and CSS as per https://codersblock.com/blog/highlight-text-inside-a-textarea/ - this looks promising but complicated any could be hard to maintain

I just briefly scrolled over this. I think this is the way to go. We can abstract it out to a new component, HighlightableTextArea or something. Shouldn't be an issue with maintenance as long as we make the component robust for this use case.