zaproxy / zaproxy

The ZAP core project
https://www.zaproxy.org
Apache License 2.0
12.21k stars 2.21k forks source link

Search in notes #8518

Open SkypLabs opened 1 week ago

SkypLabs commented 1 week ago

Is your feature request related to a problem? Please describe.

It is currently not possible to search in notes.

Describe the solution you'd like

I would like to be able to search into the notes I have taken.

Notes should be added to the drop-down menu for the search scope, along with URL, Tag, HTTP Fuzzer Results, etc.

Screenshot_20240614_120208

Describe alternatives you've considered

N/A

Screenshots

No response

Additional context

No response

Would you like to help fix this issue?

kingthorin commented 1 week ago

Here's the PR where I added the tag search support: https://github.com/zaproxy/zaproxy/issues/8422

thc202 commented 1 week ago

Be good if it was explained what's the expected behaviour, e.g. do you want to see the notes or the messages that have a note with a given regex.

SkypLabs commented 1 week ago

Here's the PR where I added the tag search support: #8422

Thanks! I should have time to work on it in a few days.

Be good if it was explained what's the expected behaviour, e.g. do you want to see the notes or the messages that have a note with a given regex.

Good point. I actually didn't feel the need to give more details as the current behaviour seems good to me. When searching for a term (e.g. URL, tag), both the request and the match string are displayed.

thc202 commented 1 week ago

Is the whole note going to be displayed or just the exact match (and the user will have to go see the note through the context menu)? The tags and matches are usually shorter than notes.

SkypLabs commented 4 days ago

Is the whole note going to be displayed or just the exact match (and the user will have to go see the note through the context menu)? The tags and matches are usually shorter than notes.

I imagine displaying a fraction of the note, like a few words before and after the exact match. I'm not sure it's the best approach but I think I will experiment a bit and see how it goes.