search

zaproxy / zest

Mozilla Public License 2.0
102 stars 36 forks source link

Update Gradle to 7.0 #227

Closed thc202 closed 3 years ago

thc202 commented 3 years ago

Update Gradle Wrapper and build to 7.0. Update Spotless to 5.12.1. Migrate CI tweaks to GitHub, missed in #224.

thc202 commented 3 years ago

Browser tests are failing for some reason (they are passing locally).

kingthorin commented 3 years ago

Amend and push again?

thc202 commented 3 years ago

Just checked (in a private repo) with the main branch and it has the same problem. Will continue investigating...

kingthorin commented 3 years ago

Is checkout@v2 really usually the original v2 and not one of the newer versions that falls back to default branch? (Checking out master not main?) I haven’t read through the logs, sorry if it’s obvious.

thc202 commented 3 years ago

Generally it should checkout the one that's being acted upon. (This repo no longer has the master branch.)

kingthorin commented 3 years ago

Agreed I just wondered if 2.0 had it hard coded because fallback wasn’t added till 2.3 or something like that.

kingthorin commented 3 years ago

Okay I finally read the log, I guess it isn’t checkout. The code is there and it is UnitTests which are failing.

thc202 commented 3 years ago

Right, that's what I tried to say with https://github.com/zaproxy/zest/pull/227#issuecomment-822376525

thc202 commented 3 years ago

This is now passing again (no changes...).

kingthorin commented 3 years ago

I'm fine with it being merged. It could have been something timing or infrastructure related.

thc202 commented 3 years ago

Done :)

thc202 commented 3 years ago

Build passed in main branch.