zaps166 / QMPlay2

QMPlay2 is a video and audio player which can play most formats and codecs.
GNU Lesser General Public License v3.0
857 stars 179 forks source link

improve fetching of lyrics. #114

Closed penguin31 closed 7 years ago

penguin31 commented 7 years ago

Sometimes qmplay2 does do not find lyrics of songs. I use cmus and mocp as terminal mp3 players and clyrisc of trixen (Daniel Șuteu) > https://github.com/trizen/clyrics,to fetch and show lyrics lyrics.Very rarely clyrics does not find lyrics.Have a look in list of lyric sites: https://github.com/trizen/clyrics/tree/master/plugins. Would be worthy to add some of lyrics sites to qmplay2. Another site that fetches lyrics for cmus : https://github.com/hakerdefo/cmus-lyrics also another one : https://github.com/febuiles/makeitpersonal

zaps166 commented 7 years ago

Sometimes qmplay2 does do not find lyrics of songs.

Does those lyrics exist on http://tekstowo.pl ? Or is it QMPlay2 bug which cannot find it ? Please notice, that you must have valid metadata - QMPlay2 doesn't extract artist and title from file name.

penguin31 commented 7 years ago

I mean, the same song/songs.Played in deadbeef, clementine, audacious, qmplay2 or qmmp also played in cmus/or mocp. Clyrics beats them all.As I said, Very rarely Clyrics does not find lyrics.I am far way from my laptop now to give a real example.

zaps166 commented 7 years ago

https://makeitpersonal.co/lyrics?artist=Myartist&title=Mytitle looks good and it is easy to implement 👍