search

zaps166 / QMPlay2

QMPlay2 is a video and audio player which can play most formats and codecs.
GNU Lesser General Public License v3.0
845 stars 176 forks source link

[feature request] use more common/useful EQ bands #163

Open kn00tcn opened 6 years ago

kn00tcn commented 6 years ago

winamp & tons of software since then, including VLC or audacious, are using the following eq bands: 60, 170, 310, 600, 1k, 3k, 6k, 12k, 14k, 16k

it would be great if qmplay2 does the same so that presets can be reused across multiple software

i was wondering why winamp chose those numbers, but the more i research & think about it, the more i realize they are very much musical, 60 is kick/bass, 170 is snare, 12k 14k 16k would be different types of hats or vinyl correction

edit: maybe i should have looked at the code first to see if i can attempt a pull request for code practice

zaps166 commented 6 years ago

maybe i should have looked at the code first to see if i can attempt a pull request for code practice

IIRC there is a function which generates frequency list from min to max (values from settings window) and how much of them (also from settings window).

kn00tcn commented 6 years ago

oh, i see that option... so it's dynamically generated bands, no wonder i saw nothing in the code such as '732'

i still think it's useful to have an option to use the hardcoded specific frequencies above, but dont know how hard it would be to implement