search

zaps166 / QMPlay2

QMPlay2 is a video and audio player which can play most formats and codecs.
GNU Lesser General Public License v3.0
838 stars 174 forks source link

[Idea] New icons for modules or more... #34

Closed varlesh closed 8 years ago

varlesh commented 8 years ago

Your icons have different style, i'm create new. Maybe you like that? :) screenshot_20160628_091837 Now available 32px icons for modules on SVG.

zaps166 commented 8 years ago

playlist

Looks very good, but on blue selection the arrow is almost invisible (depends on style and color scheme). Maybe it should be dark-blue or like https://github.com/zaps166/QMPlay2/issues/34#issuecomment-230166599 (only arrow)?

varlesh commented 8 years ago

fixed

varlesh commented 8 years ago

build for xenial soon available?

zaps166 commented 8 years ago

Xenial == Ubuntu 16.04 - DEB is already here https://github.com/zaps166/QMPlay2/releases/tag/16.07.02 (Ubuntu 15.10, 16.04, Mint 18) for yesterdays release.

varlesh commented 8 years ago

ok

varlesh commented 8 years ago

Context menu only for Windows? On Linux this icons really not needed, because better use native icons... but only for Modules, because this icons specific and not available on freedesktop icon themes and other too.

zaps166 commented 8 years ago

How to create svgz from command line ?

varlesh commented 8 years ago

ou... i don't know. maybe on inkscape

zaps166 commented 8 years ago

Context menu only for Windows?

Ah Ok, so if I'll use more theme icons in context menu then I'll notify you about it:)

On Linux this icons really not needed, because better use native icons...

It depends - sometimes it can't find, sometimes somebody wants to have native icons for software (QMPlay2 has option for it).

zaps166 commented 8 years ago

ou... i don't know. maybe on inkscape

Ok, maybe later - it is not necessary now (I hope inkscape can handle it in command line :smiley: ) :)

varlesh commented 8 years ago

Maybe for Windows use native icons too? It's possible? For example, list-add list-remove view-refresh and etc there are similar on Windows system. We create for modules only

varlesh commented 8 years ago

This icon already exist on all native Linux icon themes: application-exit applications-multimedia archive-remove audio-volume-high audio-volume-muted configure document-properties edit-clear edit-copy edit-find edit-paste folder-new folder-open folder-orange folder list-add list-remove media-playback-pause media-playback-start media-playback-stop media-skip-backward media-skip-forward process-stop view-fullscreen view-refresh

Why this icons really needed?

Only application-x-mswinurl maybe not available on native Linux icon theme.

zaps166 commented 8 years ago

https://github.com/zaps166/QMPlay2/tree/new-icons - pushed a commit to temporary branch

Looks like "application-x-mswinurl" is KDE-only (Breeze and Oxygen).

Why this icons really needed?

Windows, OS X, whatever (Android) and for QMPlay2's native icons (can be visible also on Linux if someone wants it) :)

varlesh commented 8 years ago

Oh no! For Linux only native (if available)!!!

zaps166 commented 8 years ago

Oh no! For Linux only native (if available)!!!

  1. It depends on user :)
  2. It depends on software (i.e. game or special software with own themes + linux-native icon will look bad and inconsistent).
  3. What if someone has ugly theme-icons and he/she wants to have native icons in software?
  4. If available - yes, so it must exists if not available or if it is a bug somewhere (e.g. Manjaro (Arch Linux), Qt4 and Mate desktop - can't find icons from theme).
varlesh commented 8 years ago

Linux have more beautiful icon themes - Breeze, Numix, Moka, Nitrux, Faenza and etc. Please not hardcoded icons - it's not linux way.

varlesh commented 8 years ago

More Linux users like customize your distro and DE

zaps166 commented 8 years ago

Please not hardcoded icons - it's not linux way.

QMPlay2 has two options and it will not change (settings):

You will be always able to use linux-theme icons :)

varlesh commented 8 years ago

See, this really beautiful - all look very good in the same style: screenshot_20160703_222438 And compare with Windows 10 :)

zaps166 commented 8 years ago

And compare with Windows 10 :)

Windows 10 is ugly for me :smiley: Windows 3.11 looks much better :)

varlesh commented 8 years ago

Windows 10 ugly for me too, i hate Windows and MS. Ok.. we create 16px icons later, i go sleep

zaps166 commented 8 years ago

Ok!

desktop

BlueMenta GTK2 theme + Qt GTK2 style + Oxygen icons.

zaps166 commented 8 years ago

I like customizable software, so I want to add many options (also for icons & styles & colors) into QMPlay2. It is not good if developers forces their conception to others without allowing them to change it (e.g. Windows 10 and forced auto-updates, you can only disable completely the service or Window themes in Windows - how to change it?).

Currently key bindings are in QMPlay2 TODO list.

zaps166 commented 8 years ago

Non-background icons (merged into new-icons branch):

Maybe Game-Music-Emu can have other icon - something like old game console?

Examples (bad looking on playlist): ct mp

Missing icons:

zaps166 commented 8 years ago

Maybe also other icons for VDPAU (something with nvidia) and VA-API (something with intel)? Or just graphics card in icon for both? Or mixed FFmpeg + Graphics card? On dark background.

zaps166 commented 8 years ago

Hmm, maybe use FFmpeg icon for playlist? I wrote that it is OK, but it is too light.

zaps166 commented 8 years ago

The icons w/o background: https://github.com/zaps166/QMPlay2/tree/8372cc5898312dee8a460ab4436941a142b868e8/src/svg/Concept/modules/NoBackground

zaps166 commented 8 years ago

Or just add gradient to non-bg FFmpeg icon and use darker green colors :)

zaps166 commented 8 years ago

we create 16px icons later

Is it necessary? 16x16 are very small and they are only in context menus and only when non-linux theme is used...

Ah Ok, so if I'll use more theme icons in context menu then I'll notify you about it:)

Not really necessary, so let's deffer it :)

varlesh commented 8 years ago

Please post list wrong icons (with comments, if need), it's will be better for me and you. For example, 16px - Modplug 16px - AudioCD ... and etc

zaps166 commented 8 years ago

Modules icons for playlist needed (w/o background). Removing only background looks bad (https://github.com/zaps166/QMPlay2/tree/8372cc5898312dee8a460ab4436941a142b868e8/src/svg/Concept/modules/NoBackground):

Missing icons:

varlesh commented 8 years ago

Missing icons size?

zaps166 commented 8 years ago

Missing icons size?

Updated, now it also has icon sizes

zaps166 commented 8 years ago

Icons are Inkscape SVG or Plain SVG ?

varlesh commented 8 years ago

inkscape svg

zaps166 commented 8 years ago

Ok, but now I've got better idea to compress icons that Inkscape:

gzip * && rename .svg.gz .svgz *.svg.gz

:) It should be the same (gzip).

varlesh commented 8 years ago

updated

zaps166 commented 8 years ago

:+1:

ToneGenerator:

** (inkscape:13623): WARNING **: Unimplemented style property SP_PROP_INTERPOLATION_FILTERS: value: linearRGB

** (inkscape:13623): WARNING **: Unimplemented style property SP_PROP_COLOR_INTERPOLATION: value: sRGB

** (inkscape:13623): WARNING **: Unimplemented style property SP_PROP_CLIP_RULE: value: nonzero

features from new Inkscape (I've got 0.48)?

varlesh commented 8 years ago

i'm use 0.91

zaps166 commented 8 years ago

Ok, looks very good thanks!

Questions:

varlesh commented 8 years ago

But intel not have discrete videocards. Red and black very good combined. Save tonegenerator as Plain SVG https://github.com/varlesh/QMPlay2-Concept/commit/811d5a9b4c1c4f184f042e47092309e5b7962cd2

zaps166 commented 8 years ago

But intel not have discrete videocards. Red and black very good combined.

Ok :smile:

Save tonegenerator as Plain SVG

If every icon is compatible with Plain SVG it can be saved in this format to reduce size - I can do it, but you should look if it is not corrupted, OK ?

varlesh commented 8 years ago

Ok

zaps166 commented 8 years ago

Done: https://github.com/zaps166/QMPlay2/commit/f52f2113698e21e80c1ddbeac6677daec74e6804

If icons are OK I'll generate PNG once again.

varlesh commented 8 years ago

When new release with new icons? ;)

zaps166 commented 8 years ago

When new release with new icons? ;)

Soon :) But currently I'm not changing the main icon - it can be replaced in Linux via icon theme (like Firefox and any other icon).

So the plain SVG are OK (not corrupted)? (created via Inkscape 0.48 from command line)

varlesh commented 8 years ago

You don't like new main icon variants? Maybe make other or modify... i don't know why show WARNING messages. Icon look as original.

varlesh commented 8 years ago

Also i found not native icon on modules Youtube an Prostopleer - "search" icon. screenshot_20160704_162421

Please fix it

zaps166 commented 8 years ago

I don't know why show WARNING messages

With plain SVG it doesn't show warning (probably my OLD inkscape - I've downgraded it to 0.48) :)

You don't like new main icon variants?

Currently main icon is the only icon created by my in 2008 for QMPlay1 and then modified for QMPlay2 in (probably in 2011, blue->green). This is the only icon created by my and it is with QMPlay from the beginning... It can be simply replaced via theme after a bugfix (f2facc5734e65a9b2a90cf9216cbffbf1c8ff7f3) :)

Also i found not native icon on modules Youtube an Prostopleer - "search" icon.

because currently it uses submodule icon.

zaps166 commented 8 years ago

Fixed: https://github.com/zaps166/QMPlay2/commit/7e7fc28d25f1a70ba8354c18f2a335a871762aa7