Closed varlesh closed 8 years ago
Looks very good, but on blue selection the arrow is almost invisible (depends on style and color scheme). Maybe it should be dark-blue or like https://github.com/zaps166/QMPlay2/issues/34#issuecomment-230166599 (only arrow)?
fixed
build for xenial soon available?
Xenial == Ubuntu 16.04 - DEB is already here https://github.com/zaps166/QMPlay2/releases/tag/16.07.02 (Ubuntu 15.10, 16.04, Mint 18) for yesterdays release.
ok
Context menu only for Windows? On Linux this icons really not needed, because better use native icons... but only for Modules, because this icons specific and not available on freedesktop icon themes and other too.
How to create svgz
from command line ?
ou... i don't know. maybe on inkscape
Context menu only for Windows?
Ah Ok, so if I'll use more theme icons in context menu then I'll notify you about it:)
On Linux this icons really not needed, because better use native icons...
It depends - sometimes it can't find, sometimes somebody wants to have native icons for software (QMPlay2 has option for it).
ou... i don't know. maybe on inkscape
Ok, maybe later - it is not necessary now (I hope inkscape can handle it in command line :smiley: ) :)
Maybe for Windows use native icons too? It's possible? For example, list-add list-remove view-refresh and etc there are similar on Windows system. We create for modules only
This icon already exist on all native Linux icon themes: application-exit applications-multimedia archive-remove audio-volume-high audio-volume-muted configure document-properties edit-clear edit-copy edit-find edit-paste folder-new folder-open folder-orange folder list-add list-remove media-playback-pause media-playback-start media-playback-stop media-skip-backward media-skip-forward process-stop view-fullscreen view-refresh
Why this icons really needed?
Only application-x-mswinurl maybe not available on native Linux icon theme.
https://github.com/zaps166/QMPlay2/tree/new-icons - pushed a commit to temporary branch
Looks like "application-x-mswinurl" is KDE-only (Breeze and Oxygen).
Why this icons really needed?
Windows, OS X, whatever (Android) and for QMPlay2's native icons (can be visible also on Linux if someone wants it) :)
Oh no! For Linux only native (if available)!!!
Oh no! For Linux only native (if available)!!!
- It depends on user :)
- It depends on software (i.e. game or special software with own themes + linux-native icon will look bad and inconsistent).
- What if someone has ugly theme-icons and he/she wants to have native icons in software?
- If available - yes, so it must exists if not available or if it is a bug somewhere (e.g. Manjaro (Arch Linux), Qt4 and Mate desktop - can't find icons from theme).
Linux have more beautiful icon themes - Breeze, Numix, Moka, Nitrux, Faenza and etc. Please not hardcoded icons - it's not linux way.
More Linux users like customize your distro and DE
Please not hardcoded icons - it's not linux way.
QMPlay2 has two options and it will not change ():
You will be always able to use linux-theme icons :)
See, this really beautiful - all look very good in the same style:
And compare with Windows 10 :)
And compare with Windows 10 :)
Windows 10 is ugly for me :smiley: Windows 3.11 looks much better :)
Windows 10 ugly for me too, i hate Windows and MS. Ok.. we create 16px icons later, i go sleep
Ok!
BlueMenta GTK2 theme + Qt GTK2 style + Oxygen icons.
I like customizable software, so I want to add many options (also for icons & styles & colors) into QMPlay2. It is not good if developers forces their conception to others without allowing them to change it (e.g. Windows 10 and forced auto-updates, you can only disable completely the service or Window themes in Windows - how to change it?).
Currently key bindings are in QMPlay2 TODO list.
Non-background icons (merged into new-icons
branch):
Maybe Game-Music-Emu can have other icon - something like old game console?
Examples (bad looking on playlist):
Missing icons:
Maybe also other icons for VDPAU (something with nvidia) and VA-API (something with intel)? Or just graphics card in icon for both? Or mixed FFmpeg + Graphics card? On dark background.
Hmm, maybe use FFmpeg icon for playlist? I wrote that it is OK, but it is too light.
Or just add gradient to non-bg FFmpeg icon and use darker green colors :)
we create 16px icons later
Is it necessary? 16x16 are very small and they are only in context menus and only when non-linux theme is used...
Ah Ok, so if I'll use more theme icons in context menu then I'll notify you about it:)
Not really necessary, so let's deffer it :)
Please post list wrong icons (with comments, if need), it's will be better for me and you. For example, 16px - Modplug 16px - AudioCD ... and etc
Modules icons for playlist needed (w/o background). Removing only background looks bad (https://github.com/zaps166/QMPlay2/tree/8372cc5898312dee8a460ab4436941a142b868e8/src/svg/Concept/modules/NoBackground):
Missing icons:
Missing icons size?
Missing icons size?
Updated, now it also has icon sizes
Icons are Inkscape SVG or Plain SVG ?
inkscape svg
Ok, but now I've got better idea to compress icons that Inkscape:
gzip * && rename .svg.gz .svgz *.svg.gz
:) It should be the same (gzip).
updated
:+1:
ToneGenerator:
** (inkscape:13623): WARNING **: Unimplemented style property SP_PROP_INTERPOLATION_FILTERS: value: linearRGB
** (inkscape:13623): WARNING **: Unimplemented style property SP_PROP_COLOR_INTERPOLATION: value: sRGB
** (inkscape:13623): WARNING **: Unimplemented style property SP_PROP_CLIP_RULE: value: nonzero
features from new Inkscape (I've got 0.48)?
i'm use 0.91
Ok, looks very good thanks!
Questions:
ToneGenerator.svg
to silence warning on old Inkscape?But intel not have discrete videocards. Red and black very good combined. Save tonegenerator as Plain SVG https://github.com/varlesh/QMPlay2-Concept/commit/811d5a9b4c1c4f184f042e47092309e5b7962cd2
But intel not have discrete videocards. Red and black very good combined.
Ok :smile:
Save tonegenerator as Plain SVG
If every icon is compatible with Plain SVG it can be saved in this format to reduce size - I can do it, but you should look if it is not corrupted, OK ?
Ok
Done: https://github.com/zaps166/QMPlay2/commit/f52f2113698e21e80c1ddbeac6677daec74e6804
If icons are OK I'll generate PNG once again.
When new release with new icons? ;)
When new release with new icons? ;)
Soon :) But currently I'm not changing the main icon - it can be replaced in Linux via icon theme (like Firefox and any other icon).
So the plain SVG are OK (not corrupted)? (created via Inkscape 0.48 from command line)
You don't like new main icon variants? Maybe make other or modify... i don't know why show WARNING messages. Icon look as original.
Also i found not native icon on modules Youtube an Prostopleer - "search" icon.
Please fix it
I don't know why show WARNING messages
With plain SVG it doesn't show warning (probably my OLD inkscape - I've downgraded it to 0.48) :)
You don't like new main icon variants?
Currently main icon is the only icon created by my in 2008 for QMPlay1 and then modified for QMPlay2 in (probably in 2011, blue->green). This is the only icon created by my and it is with QMPlay from the beginning... It can be simply replaced via theme after a bugfix (f2facc5734e65a9b2a90cf9216cbffbf1c8ff7f3) :)
Also i found not native icon on modules Youtube an Prostopleer - "search" icon.
because currently it uses submodule icon.
Your icons have different style, i'm create new. Maybe you like that? :)
Now available 32px icons for modules on SVG.