search

zapty / forever-service

Provision node script as a service via forever, allowing it to automatically start on boot, working across various Linux distros and OS
https://github.com/zapty/forever-service
MIT License
594 stars 65 forks source link

log rotation is always daily #54

Closed ericberdahl closed 8 years ago

ericberdahl commented 8 years ago

There exists a bug in the logrotate templates for both upstart and sysvinit in which the "logrotateFrequency" variable in the template is misspelled "logroateFrequency". The net result of this error is that the log rotation frequency is always specified as daily (defaulted from the template itself), regardless of the value specified by the user (via the --logrotateFrequency command line option).

arvind-agarwal commented 8 years ago

@ericberdahl thanks for pointing this out. I have fixed it can you upgrade to 0.5.6 and confirm if this works now.

ericberdahl commented 8 years ago

@arvind-agarwal Confirmed. Upgraded forever-service to 0.5.6 and ran an install. logrotate configuration file now shows the rotation frequency specified by the argument to forever-service. Thanks!