search

zapzombies / zap-community

This is a public repository used for keeping track of bugs, suggestions, and general information (see the wiki for more). If you really like our project and want to support us, see our Patreon page: https://www.patreon.com/zapzombies
GNU General Public License v3.0
1 stars 0 forks source link

Power-up configs shouldn't use the 0-based index for rounds #34

Closed ghost closed 2 years ago

ghost commented 2 years ago

Is your feature request related to a problem? Please describe. It's confusing. That's it.

Describe the solution you'd like Title. Start with 1 for round 1, etc. instead of 0.

Describe alternatives you've considered Make it a -1-based index so there's even more confusion between both coders and those doing the configuring. But seriously, there is no alternative.

Additional context None.

Steanky commented 2 years ago

if it's a 1-based index, we then need to subtract 1 from every round, since we use a 0-based index internally (otherwise we just wouldn't use the first element of the round list)

ghost commented 2 years ago

How much overhead does that really add, though?

Steanky commented 2 years ago

Not talking about overhead - it's confusing for us to have to translate between 0-based and non-zero based. we're already doing it once (to display rounds)

ghost commented 2 years ago

Seems like a lose-lose situation then.

tachibanayui commented 2 years ago

@Steanky we should take this into consideration when we remake arenaapi

Steanky commented 2 years ago

we should either use zero-based for everything or 1-based for everything, translating between the two constantly is asking for bugs

tahmid-23 commented 2 years ago

closing because we reached consensus and matlab is terrible