Use jest-image-snapshot as dependency

zaqqaz / jest-allure-image-snapshot

MIT License

1 stars 4 forks source link

Use jest-image-snapshot as dependency #7

Open kirill-konshin opened 4 years ago

kirill-konshin commented 4 years ago

Currently it's listed as dependency but looks like code has been copy-pasted instead of real usage.

I guess that's because original library has some APIs not exported to public: https://github.com/americanexpress/jest-image-snapshot/issues/129#issuecomment-590575641

kirill-konshin commented 4 years ago

I looked through the commit history, looks like in the beginning it was used directly toMatchImageSnapshot.apply(this, args) but then implementation has changed to copy-paste. Why was that? My guess is that orig library was lacking features/was slow to roullout features. Is it still the case? They are updating quite frequently now...

I suggest to add them as peerDependency and let users to choose the version they want.