zaquestion / lab

Lab wraps Git or Hub, making it simple to clone, fork, and interact with repositories on GitLab
https://zaquestion.github.io/lab
Creative Commons Zero v1.0 Universal
1.11k stars 102 forks source link

Standardize file read #746

Closed zampierilucas closed 3 years ago

zampierilucas commented 3 years ago

Changed os.Open() to ioutil.ReadFile() so we can be consisted on file reads.

Signed-off-by: Lucas Zampieri lzampier@redhat.com

codecov[bot] commented 3 years ago

Codecov Report

Merging #746 (9977dae) into master (2fb6734) will increase coverage by 0.04%. The diff coverage is 51.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   54.71%   54.76%   +0.04%     
==========================================
  Files          77       77              
  Lines        5596     5606      +10     
==========================================
+ Hits         3062     3070       +8     
- Misses       2251     2255       +4     
+ Partials      283      281       -2     
Impacted Files Coverage Δ
cmd/mr_approve.go 70.27% <33.33%> (-1.61%) :arrow_down:
cmd/mr_unapprove.go 75.00% <47.36%> (+3.12%) :arrow_up:
internal/gitlab/gitlab.go 7.09% <50.00%> (+0.02%) :arrow_up:
cmd/note_common.go 54.57% <66.66%> (-0.24%) :arrow_down:
cmd/edit_common.go 82.85% <100.00%> (-1.36%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd3d2ce...9977dae. Read the comment docs.

bmeneg commented 3 years ago

Nice thing!