search

zaquestion / lab

Lab wraps Git or Hub, making it simple to clone, fork, and interact with repositories on GitLab
https://zaquestion.github.io/lab
Creative Commons Zero v1.0 Universal
1.11k stars 102 forks source link

root: remove git wrapping code #809

Closed bmeneg closed 2 years ago

bmeneg commented 2 years ago

Remove the last piece of git passthrough code: in case a command or a flag was not recognized it was sent to git for parsing. This patch removes it and rely completely on code owned by lab. Git is still used in some places for retrieving repo information and for cloning repos with lab clone command, but no command is passed through to git anymore.

This now allow us to fully recommend users to run lab as an Git alias instead.

Signed-off-by: Bruno Meneguele bmeneg@redhat.com

This PR is required for submitting a doc change where we drop any word about "git passthrough/wrapper" in the code/repo. This PR fix #701.

codecov[bot] commented 2 years ago

Codecov Report

Merging #809 (082de37) into master (2ba2e55) will increase coverage by 0.07%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #809      +/-   ##
==========================================
+ Coverage   54.51%   54.59%   +0.07%     
==========================================
  Files          77       77              
  Lines        5723     5704      -19     
==========================================
- Hits         3120     3114       -6     
+ Misses       2311     2300      -11     
+ Partials      292      290       -2
Impacted Files Coverage Δ
cmd/clone.go 71.87% <60.00%> (-2.20%) :arrow_down:
cmd/root.go 63.52% <100.00%> (+5.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ba2e55...082de37. Read the comment docs.