search

zaquestion / lab

Lab wraps Git or Hub, making it simple to clone, fork, and interact with repositories on GitLab
https://zaquestion.github.io/lab
Creative Commons Zero v1.0 Universal
1.1k stars 103 forks source link

`lab mr merge` does not respect delete source branch #830

Open JohnVillalovos opened 2 years ago

JohnVillalovos commented 2 years ago

I create an mr using lab mr create --remove-source-branch and it shows that the source branch will be removed.

Then I do lab mr merge and then it no longer shows it will remove the source branch.

Using lab version:

$ lab --version
lab version 0.24.0
zampierilucas commented 2 years ago

Hey @JohnVillalovos thanks for reporting that.

Unfortunately I count to reproduce your issue, I've also played with the project setting under Merge Request for the default of delete source branch on merge and saw no difference in it, also I've tested on lab version v0.24.0-3-g73bada2(a bit behind master), so It should have been fixed by another commit, can you test on your project with the latest master version or g73bada2?

If that solves the issue, let me know, as I will try to speed up a 0.25.0 release to get it fixed.

JohnVillalovos commented 2 years ago

So I am doing this on an MR which is still running the CI. Not sure if that is how you tested it. So by doing lab mr merge it sets the MR to merge after the pipeline has passed.

zampierilucas commented 2 years ago

Ooh, yeah, I don't have the setting to wait for pipeline completion before merge turned on, I'll do a bit more testing and get back to you