codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 30.00% and project coverage change: -0.12 :warning:
Comparison is base (
98c3f01) 56.00% compared to head (033192f) 55.88%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #856 +/- ## ========================================== - Coverage 56.00% 55.88% -0.12% ========================================== Files 77 77 Lines 5753 5774 +21 ========================================== + Hits 3222 3227 +5 - Misses 2242 2257 +15 - Partials 289 290 +1 ``` | [Impacted Files](https://app.codecov.io/gh/zaquestion/lab/pull/856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zaq%3F+Wiedmann) | Coverage Δ | | |---|---|---| | [internal/config/config.go](https://app.codecov.io/gh/zaquestion/lab/pull/856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zaq%3F+Wiedmann#diff-aW50ZXJuYWwvY29uZmlnL2NvbmZpZy5nbw==) | `22.11% <0.00%> (-1.60%)` | :arrow_down: | | [internal/gitlab/gitlab.go](https://app.codecov.io/gh/zaquestion/lab/pull/856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zaq%3F+Wiedmann#diff-aW50ZXJuYWwvZ2l0bGFiL2dpdGxhYi5nbw==) | `8.61% <44.44%> (+0.25%)` | :arrow_up: | | [cmd/ci\_lint.go](https://app.codecov.io/gh/zaquestion/lab/pull/856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zaq%3F+Wiedmann#diff-Y21kL2NpX2xpbnQuZ28=) | `87.50% <100.00%> (+1.78%)` | :arrow_up: | | [cmd/issue\_browse.go](https://app.codecov.io/gh/zaquestion/lab/pull/856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zaq%3F+Wiedmann#diff-Y21kL2lzc3VlX2Jyb3dzZS5nbw==) | `100.00% <100.00%> (ø)` | | | [cmd/mr\_browse.go](https://app.codecov.io/gh/zaquestion/lab/pull/856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zaq%3F+Wiedmann#diff-Y21kL21yX2Jyb3dzZS5nbw==) | `100.00% <100.00%> (ø)` | | | [cmd/mr\_edit.go](https://app.codecov.io/gh/zaquestion/lab/pull/856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zaq%3F+Wiedmann#diff-Y21kL21yX2VkaXQuZ28=) | `64.07% <100.00%> (ø)` | | | [cmd/snippet\_browse.go](https://app.codecov.io/gh/zaquestion/lab/pull/856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zaq%3F+Wiedmann#diff-Y21kL3NuaXBwZXRfYnJvd3NlLmdv) | `85.00% <100.00%> (ø)` | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
claytonrcarter
Like #855, this also deals with a breaking change in GL 16.0. In this case, support for "legacy" URLs has been removed, and this is also breaking
lab issue browse,... mr browse, and... snippet browse. This change should update all of these so that they work again.BREAKING As I understand it, these delimited URLs should work on any version of GL since v9 (2017) but these changes will bread the browse commands for users of older versions. If this is a concern, I suppose we could use a config flag to control the URL format.
FMI Deprecation notice: https://docs.gitlab.com/ee/update/deprecations.html?removal_milestone=16.0#legacy-urls-replaced-or-removed List of affected URLs: https://gitlab.com/gitlab-org/gitlab/-/issues/28848#release-notes