search

zardoru / raindrop

yet another beatgame.
GNU General Public License v3.0
128 stars 16 forks source link

Unix directory fixes. #9

Closed Geenz closed 9 years ago

Geenz commented 9 years ago

Just before we convert from Shift-JIS to UTF-8, this code will replace all occurrences of '\' with '/' on OS X and Linux. I'm not sure if this should also apply to Windows. This seems to resolve (most) file loading issues on OS X. This does not include the retry code I previously committed.

zardoru commented 9 years ago

Hmm, to be honest, I'm not very fond of altering a character-conversion function for handling paths. I'd rather have a proper PathNormalize function that removes redundant slashes, replaces backslashes with forward slashes and removes illegal characters. This is achievable in about 3 lines or so.

Geenz commented 9 years ago

I'll deal with that when I get home. In the Directory class I assume?

Sent from my iPhone

On Mar 13, 2015, at 1:29 PM, Diego Ahumada notifications@github.com wrote:

Hmm, to be honest, I'm not very fond of altering a character-conversion function for handling paths. I'd rather have a proper PathNormalize function that removes redundant slashes, replaces backslashes with forward slashes and removes illegal characters. This is achievable in about 3 lines or so.

\ Reply to this email directly or view it on GitHub.

zardoru commented 9 years ago

Yep.

zardoru commented 9 years ago

This should be fixed by now.