search

zardoy / minecraft-web-client

The most advanced Minecraft online/offline client + server in your browser! [IOS SUPPORTED]
https://mcraft.fun
MIT License
31 stars 31 forks source link

Format disconnect messages #26

Open zardoy opened 11 months ago

zardoy commented 11 months ago

Issuehunt badges

We already format chat & death messages. Let's refactor loading & error screen to React and use the same logic as for death screen, this should be easy. Also need to ensure that long kick messages are scrollable and don't overflow buttons (+ensure have global scroll bar styles).

examples. This is not readable at all:

image

IssueHunt Summary ### Backers (Total: $50.00) - [zardoy zardoy](https://oss.issuehunt.io/u/zardoy) ($50.00) #### [Become a backer now!](https://oss.issuehunt.io/r/zardoy/prismarine-web-client/issues/26) #### [Or submit a pull request to get the deposits!](https://oss.issuehunt.io/r/zardoy/prismarine-web-client/issues/26) ### Tips - Checkout the [Issuehunt explorer](https://oss.issuehunt.io/r/zardoy/prismarine-web-client/) to discover more funded issues. - Need some help from other developers? [Add your repositories](https://oss.issuehunt.io/r/new) on IssueHunt to raise funds.
issuehunt-oss[bot] commented 11 months ago

@zardoy has funded $10.00 to this issue.

raghavpatidar commented 11 months ago

I want to work please tell me how to regenerate above issue

zardoy commented 11 months ago

Hey @raghavpatidar! To reproduce:

You should see raw JSON text displayed, instead the json should be parsed and used with MessageFormattedString.tsx (from next branch)

I was adding storybook support on the next branch, so it's easier to develop React components. You can see how DeathScreen is used in combination with StoryBook: https://github.com/zardoy/prismarine-web-client/blob/d77484c9662819edda8fe88424e9ea0190bd152b/src/react/DeathScreen.stories.tsx#L24-L25 You might want to do new React component in the same fashion (I mean refactor loading_or_error_screen.js) Now refactored to React. See AppStatus.tsx

issuehunt-oss[bot] commented 10 months ago

@zardoy has funded $40.00 to this issue.

pablo-albaladejo commented 10 months ago

Hi @zardoy,

Im trying to reproduce the issue locally but Im not able to connect to the server according the provided instructions

Start npm script test-mc-server Start npm script start open localhost:8080 connect to server by ip localhost In terminal with npm script test-mc-server write kick like kick testbot

Everything seems to be up and running but connection can not be done:

But when trying to connect Screenshot from 2023-11-24 11-36-28

Could you help with the setup?

zardoy commented 10 months ago

Sorry for the delay. In MC version plays a crucial role, open mc server file - just because it set to run with version 1.16.1, it runs with version 1.16.1. And here you are connecting from the web client with version 1.18.1. Another question is why auto-version doesn't work sometimes and there is no proper error message when you connect to flying-squid with the wrong version. I think most probably there is an issue specific to flying-squid js impl, need to look into protocol stuff because I definitely remember I didn't have such issues with native java servers. Flying squid is totally okay for simple testing as it is fast & portable, but of course, for bigger testing or adding more serious features I always use native servers remotely/locally.

zardoy commented 1 month ago

test fund

zardoy commented 1 month ago

/bounty $20

algora-pbc[bot] commented 1 month ago

💎 $20 bounty • Vitaly

💎 $10 bounty • denzig98

Steps to solve:

  1. Start working: Comment /attempt #26 with your implementation plan
  2. Submit work: Create a pull request including /claim #26 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zardoy/minecraft-web-client!

Add a bounty • Share on socials