zardoy / typescript-vscode-plugins

NO LIMITS FOR TS! Isn't this the most advanced TypeScript plugin as VS Code extension ever created?
https://marketplace.visualstudio.com/items?itemName=zardoy.ts-essential-plugins
MIT License
55 stars 5 forks source link

feat(refactoring): add/from destructure bug fixes, `this` keyword support #183

Closed Ilanaya closed 10 months ago

Ilanaya commented 10 months ago

Closes #167

Ilanaya commented 10 months ago

@zardoy Can you please help to reproduce the issue with highlights in type nodes? I somehow forgot the case :(

Obviously we shouldn't display code action at all in cases like this (with typeof):

const obj = {
  test: 1,
}
obj.test

type foo = typeof obj

I'm trying different variations of this code but it works fine...

type obj = {
  foo: 1,
  obj: 3
}

const test = /** @type {obj} */('asdf')

const obj = {
  test: 1,
}
obj.test
zardoy commented 10 months ago

@Ilanaya This one:

/**
 * 
 * @param a 
 */
const a = (a) => {
    a // here
}
Ilanaya commented 10 months ago

@Ilanaya This one:

/**
 * 
 * @param a 
 */
const a = (a) => {
    a // here
}

@zardoy I can't reproduce with this code and its variations; I may have added stricter checks somewhere. By the way, can we install prettier as dev dep in the project? I always get conflicts with the ci's npx prettier as it uses prettier v3.1 when vscode's extension currently works with v2 by default

zardoy commented 10 months ago

I can't reproduce with this code and its variations; I may have added stricter checks somewhere.

ok, feel free to merge.

And what about prettier the answer is yes, i thought prettier was already installed so feel free to do it since npx prefers local packages. btw didn't know they downgraded prettier in the extension

Ilanaya commented 10 months ago

Merging now. Vue support needs more effort than I expected.

Can we, please, release it ASAP? This code action version is much more stable than in the current release.