search

zardoy / vscode-better-snippets

Create most advanced snippets for VSCode in existence
https://marketplace.visualstudio.com/items?itemName=zardoy.better-snippets
MIT License
6 stars 0 forks source link

fix: now extension's typing snippets are usable within live share sessions #30

Closed zardoy closed 1 year ago

zardoy commented 1 year ago

mostly fixes #11 , but there is still a problem when both cursors (host and some guest) are on the same location at the file, but it is possible to workaround this problem as well with kind from onDidChangeTextEditorSelection which is command on other side change I think, but I wont focus on it for now

Ilanaya commented 1 year ago

I didn't even reproduce the issue - typing snippets work fine when I start live share and use the vscode's web version as the second participant.

However I recall some issues when we used live share together and if you wan't me investigate and try to fix them, please, provide some steps to reproduce or smth as I don't understand what is going wrong rn :(

zardoy commented 1 year ago

Thanks but I already fixed it in this pr and didn’t mean you to fix it 🎉 you needed to have better snippets installed on both sides and have the same typing snippets. The problem was is that typing a typing snippet on guest side would also trigger it on the host side.